Page MenuHomePhabricator

D18529.diff
No OneTemporary

D18529.diff

diff --git a/src/applications/differential/controller/DifferentialDiffCreateController.php b/src/applications/differential/controller/DifferentialDiffCreateController.php
--- a/src/applications/differential/controller/DifferentialDiffCreateController.php
+++ b/src/applications/differential/controller/DifferentialDiffCreateController.php
@@ -182,10 +182,10 @@
->setValue($button));
$form_box = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Diff'))
+ ->setHeaderText($title)
->setValidationException($validation_exception)
->setForm($form)
- ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+ ->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
->setFormErrors($errors);
$crumbs = $this->buildApplicationCrumbs();
@@ -197,15 +197,10 @@
$crumbs->addTextCrumb($title);
$crumbs->setBorder(true);
- $header = id(new PHUIHeaderView())
- ->setHeader($title)
- ->setHeaderIcon($header_icon);
-
$view = id(new PHUITwoColumnView())
- ->setHeader($header)
->setFooter(array(
- $info_view,
$form_box,
+ $info_view,
));
return $this->newPage()
diff --git a/src/view/phui/PHUIInfoView.php b/src/view/phui/PHUIInfoView.php
--- a/src/view/phui/PHUIInfoView.php
+++ b/src/view/phui/PHUIInfoView.php
@@ -59,6 +59,7 @@
} else {
$icon = id(new PHUIIconView())
->setIcon($icon);
+ $this->icon = $icon;
}
return $this;

File Metadata

Mime Type
text/plain
Expires
Mon, May 13, 11:43 PM (3 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6294098
Default Alt Text
D18529.diff (1 KB)

Event Timeline