Page MenuHomePhabricator

D7443.diff
No OneTemporary

D7443.diff

Index: src/applications/differential/conduit/ConduitAPI_differential_parsecommitmessage_Method.php
===================================================================
--- src/applications/differential/conduit/ConduitAPI_differential_parsecommitmessage_Method.php
+++ src/applications/differential/conduit/ConduitAPI_differential_parsecommitmessage_Method.php
@@ -169,6 +169,38 @@
$fields[$name] = $data;
}
+ // This is another piece of special-cased magic which allows you to
+ // enter a ridiculously long title, or just type a big block of stream
+ // of consciousness text, and have some sort of reasonable result conjured
+ // from it.
+ if (isset($fields['title'])) {
+ $terminal = '...';
+ $title = $fields['title'];
+ $short = phutil_utf8_shorten($title, 250, $terminal);
+ if ($short != $title) {
+
+ // If we shortened the title, split the rest into the summary, so
+ // we end up with a title like:
+ //
+ // Title title tile title title...
+ //
+ // ...and a summary like:
+ //
+ // ...title title title.
+ //
+ // Summary summary summary summary.
+
+ $summary = idx($fields, 'summary', '');
+ $offset = strlen($short) - strlen($terminal);
+ $remainder = ltrim(substr($fields['title'], $offset));
+ $summary = '...'.$remainder."\n\n".$summary;
+ $summary = rtrim($summary, "\n");
+
+ $fields['title'] = $short;
+ $fields['summary'] = $summary;
+ }
+ }
+
return $fields;
}

File Metadata

Mime Type
text/plain
Expires
May 13 2024, 10:52 PM (4 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6293530
Default Alt Text
D7443.diff (1 KB)

Event Timeline