Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13192979
D18570.id44583.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D18570.id44583.diff
View Options
diff --git a/src/applications/herald/controller/HeraldRuleController.php b/src/applications/herald/controller/HeraldRuleController.php
--- a/src/applications/herald/controller/HeraldRuleController.php
+++ b/src/applications/herald/controller/HeraldRuleController.php
@@ -238,8 +238,6 @@
? pht('Edit Herald Rule: %s', $rule->getName())
: pht('Create Herald Rule: %s', idx($content_type_map, $content_type));
- $icon = $rule->getID() ? 'fa-pencil' : 'fa-plus-square';
-
$form_box = id(new PHUIObjectBoxView())
->setHeaderText($title)
->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
diff --git a/src/applications/passphrase/controller/PassphraseCredentialCreateController.php b/src/applications/passphrase/controller/PassphraseCredentialCreateController.php
--- a/src/applications/passphrase/controller/PassphraseCredentialCreateController.php
+++ b/src/applications/passphrase/controller/PassphraseCredentialCreateController.php
@@ -52,17 +52,12 @@
$crumbs->setBorder(true);
$box = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Credential'))
+ ->setHeaderText($title)
->setFormErrors($errors)
- ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+ ->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
->setForm($form);
- $header = id(new PHUIHeaderView())
- ->setHeader($title)
- ->setHeaderIcon('fa-plus-square');
-
$view = id(new PHUITwoColumnView())
- ->setHeader($header)
->setFooter($box);
return $this->newPage()
diff --git a/src/applications/passphrase/controller/PassphraseCredentialEditController.php b/src/applications/passphrase/controller/PassphraseCredentialEditController.php
--- a/src/applications/passphrase/controller/PassphraseCredentialEditController.php
+++ b/src/applications/passphrase/controller/PassphraseCredentialEditController.php
@@ -250,10 +250,6 @@
->setLabel(pht('Description'))
->setValue($v_desc))
->appendChild(
- id(new AphrontFormMarkupControl())
- ->setLabel(pht('Credential Type'))
- ->setValue($type->getCredentialTypeName()))
- ->appendChild(
id(new AphrontFormDividerControl()))
->appendControl(
id(new AphrontFormPolicyControl())
@@ -322,10 +318,9 @@
$crumbs->setBorder(true);
if ($is_new) {
- $title = pht('Create New Credential');
+ $title = pht('New Credential: %s', $type->getCredentialTypeName());
$crumbs->addTextCrumb(pht('Create'));
$cancel_uri = $this->getApplicationURI();
- $header_icon = 'fa-plus-square';
} else {
$title = pht('Edit Credential: %s', $credential->getName());
$crumbs->addTextCrumb(
@@ -333,7 +328,6 @@
'/K'.$credential->getID());
$crumbs->addTextCrumb(pht('Edit'));
$cancel_uri = '/K'.$credential->getID();
- $header_icon = 'fa-pencil';
}
if ($request->isAjax()) {
@@ -356,18 +350,13 @@
->addCancelButton($cancel_uri));
$box = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Credential'))
+ ->setHeaderText($title)
->setFormErrors($errors)
->setValidationException($validation_exception)
- ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+ ->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
->setForm($form);
- $header = id(new PHUIHeaderView())
- ->setHeader($title)
- ->setHeaderIcon($header_icon);
-
$view = id(new PHUITwoColumnView())
- ->setHeader($header)
->setFooter(array(
$box,
));
File Metadata
Details
Attached
Mime Type
text/plain
Expires
May 13 2024, 11:08 AM (4 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6292705
Default Alt Text
D18570.id44583.diff (3 KB)
Attached To
Mode
D18570: Update passphrase edit UI
Attached
Detach File
Event Timeline
Log In to Comment