Page MenuHomePhabricator

D13216.diff
No OneTemporary

D13216.diff

diff --git a/src/applications/files/query/PhabricatorFileQuery.php b/src/applications/files/query/PhabricatorFileQuery.php
--- a/src/applications/files/query/PhabricatorFileQuery.php
+++ b/src/applications/files/query/PhabricatorFileQuery.php
@@ -142,6 +142,14 @@
foreach ($files as $file) {
$phids = array_keys($edges[$file->getPHID()][$edge_type]);
$file->attachObjectPHIDs($phids);
+
+ if ($file->getIsProfileImage()) {
+ // If this is a profile image, don't bother loading related files.
+ // It will always be visible, and we can get into trouble if we try
+ // to load objects and end up stuck in a cycle. See T8478.
+ continue;
+ }
+
foreach ($phids as $phid) {
$object_phids[$phid] = true;
}

File Metadata

Mime Type
text/plain
Expires
Sun, May 12, 6:06 AM (3 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6290479
Default Alt Text
D13216.diff (781 B)

Event Timeline