Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13186992
D11119.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
950 B
Referenced Files
None
Subscribers
None
D11119.diff
View Options
diff --git a/src/applications/base/PhabricatorApplication.php b/src/applications/base/PhabricatorApplication.php
--- a/src/applications/base/PhabricatorApplication.php
+++ b/src/applications/base/PhabricatorApplication.php
@@ -28,23 +28,7 @@
/* -( Application Information )-------------------------------------------- */
-
- /**
- * TODO: This should be abstract, but is not for historical reasons.
- */
- public function getName() {
- phutil_deprecated(
- 'Automatic naming of `PhabricatorApplication` classes.',
- 'You should override the `getName` method.');
-
- $match = null;
- $regex = '/^PhabricatorApplication([A-Z][a-zA-Z]*)$/';
- if (preg_match($regex, get_class($this), $match)) {
- return $match[1];
- }
-
- throw new PhutilMethodNotImplementedException();
- }
+ public abstract function getName();
public function getShortDescription() {
return $this->getName().' Application';
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, May 12, 4:15 AM (3 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6288683
Default Alt Text
D11119.diff (950 B)
Attached To
Mode
D11119: Make the `PhabricatorApplication::getName()` method abstract
Attached
Detach File
Event Timeline
Log In to Comment