Page MenuHomePhabricator

D11119.diff
No OneTemporary

D11119.diff

diff --git a/src/applications/base/PhabricatorApplication.php b/src/applications/base/PhabricatorApplication.php
--- a/src/applications/base/PhabricatorApplication.php
+++ b/src/applications/base/PhabricatorApplication.php
@@ -28,23 +28,7 @@
/* -( Application Information )-------------------------------------------- */
-
- /**
- * TODO: This should be abstract, but is not for historical reasons.
- */
- public function getName() {
- phutil_deprecated(
- 'Automatic naming of `PhabricatorApplication` classes.',
- 'You should override the `getName` method.');
-
- $match = null;
- $regex = '/^PhabricatorApplication([A-Z][a-zA-Z]*)$/';
- if (preg_match($regex, get_class($this), $match)) {
- return $match[1];
- }
-
- throw new PhutilMethodNotImplementedException();
- }
+ public abstract function getName();
public function getShortDescription() {
return $this->getName().' Application';

File Metadata

Mime Type
text/plain
Expires
Sun, May 12, 4:15 AM (3 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6288683
Default Alt Text
D11119.diff (950 B)

Event Timeline