Page MenuHomePhabricator

D20460.diff
No OneTemporary

D20460.diff

diff --git a/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php b/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
@@ -100,8 +100,17 @@
$this->renderAuthor());
}
- $author_phid = $commit->getAuthorDisplayPHID();
- $committer_phid = $commit->getCommitterDisplayPHID();
+ $author_phid = null;
+ if ($commit->hasAuthorIdentity()) {
+ $identity = $commit->getAuthorIdentity();
+ $author_phid = $identity->getIdentityDisplayPHID();
+ }
+
+ $committer_phid = null;
+ if ($commit->hasCommitterIdentity()) {
+ $identity = $commit->getCommitterIdentity();
+ $committer_phid = $identity->getIdentityDisplayPHID();
+ }
if (!$author_phid) {
return pht(

File Metadata

Mime Type
text/plain
Expires
Sun, May 12, 3:23 AM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6283341
Default Alt Text
D20460.diff (944 B)

Event Timeline