Page MenuHomePhabricator
Files F13185843

D12775.diff
No OneTemporary
Actions

D12775.diff
View Options

diff --git a/src/applications/differential/constants/DifferentialRevisionStatus.php b/src/applications/differential/constants/DifferentialRevisionStatus.php
--- a/src/applications/differential/constants/DifferentialRevisionStatus.php
+++ b/src/applications/differential/constants/DifferentialRevisionStatus.php
@@ -57,6 +57,28 @@
return idx($map, $status, $default);
}
+ public static function getRevisionStatusIconCircle($status) {
+ $default = 'fa-circle-o bluegrey';
+
+ $map = array(
+ ArcanistDifferentialRevisionStatus::NEEDS_REVIEW =>
+ 'fa-circle-o bluegrey',
+ ArcanistDifferentialRevisionStatus::NEEDS_REVISION =>
+ 'fa-times-circle red',
+ ArcanistDifferentialRevisionStatus::CHANGES_PLANNED =>
+ 'fa-exclamation-circle red',
+ ArcanistDifferentialRevisionStatus::ACCEPTED =>
+ 'fa-check-circle green',
+ ArcanistDifferentialRevisionStatus::CLOSED =>
+ 'fa-check-circle',
+ ArcanistDifferentialRevisionStatus::ABANDONED =>
+ 'fa-times-circle',
+ ArcanistDifferentialRevisionStatus::IN_PREPARATION =>
+ 'fa-question-circle blue',
+ );
+ return idx($map, $status, $default);
+ }
+
public static function renderFullDescription($status) {
$color = self::getRevisionStatusColor($status);
$status_name =
diff --git a/src/applications/phid/PhabricatorObjectHandle.php b/src/applications/phid/PhabricatorObjectHandle.php
--- a/src/applications/phid/PhabricatorObjectHandle.php
+++ b/src/applications/phid/PhabricatorObjectHandle.php
@@ -282,6 +282,21 @@
->setIconFont('fa-lock lightgreytext');
}
+ if ($this->getType() == DifferentialRevisionPHIDType::TYPECONST) {
+ $revision = id(new DifferentialRevisionQuery())
+ ->setViewer(PhabricatorUser::getOmnipotentUser())
+ ->withPHIDs(array($this->getPHID()))
+ ->needReviewerStatus(true)
+ ->executeOne();
+
+ if ($revision) {
+ $font = DifferentialRevisionStatus::getRevisionStatusIconCircle(
+ $revision->getStatus());
+ $icon = id(new PHUIIconView())
+ ->setIconFont($font);
+ }
+ }
+
return phutil_tag(
$uri ? 'a' : 'span',
array(

File Metadata

Mime Type
text/plain
Expires
Sun, May 12, 3:15 AM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6287811
Default Alt Text
D12775.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility