Page MenuHomePhabricator
Files F13185068

D8240.diff
No OneTemporary
Actions

D8240.diff
View Options

Index: src/applications/differential/controller/DifferentialInlineCommentEditController.php
===================================================================
--- src/applications/differential/controller/DifferentialInlineCommentEditController.php
+++ src/applications/differential/controller/DifferentialInlineCommentEditController.php
@@ -60,8 +60,9 @@
return false;
}
- // Saved comments may not be edited.
- if ($inline->getCommentID()) {
+ // Saved comments may not be edited, for now, although the schema now
+ // supports it.
+ if (!$inline->isDraft()) {
return false;
}
Index: src/applications/differential/query/DifferentialInlineCommentQuery.php
===================================================================
--- src/applications/differential/query/DifferentialInlineCommentQuery.php
+++ src/applications/differential/query/DifferentialInlineCommentQuery.php
@@ -45,11 +45,6 @@
return $this;
}
- public function withCommentIDs(array $comment_ids) {
- $this->commentIDs = $comment_ids;
- return $this;
- }
-
public function execute() {
$table = new DifferentialTransactionComment();
$conn_r = $table->establishConnection('r');
@@ -155,13 +150,6 @@
$this->draftsByAuthors);
}
- if ($this->commentIDs) {
- $where[] = qsprintf(
- $conn_r,
- 'legacyCommentID IN (%Ld)',
- $this->commentIDs);
- }
-
return $this->formatWhereClause($where);
}
Index: src/applications/differential/storage/DifferentialInlineComment.php
===================================================================
--- src/applications/differential/storage/DifferentialInlineComment.php
+++ src/applications/differential/storage/DifferentialInlineComment.php
@@ -167,7 +167,6 @@
// the future transaction.
public function setCommentID($id) {
- $this->proxy->setLegacyCommentID($id);
$this->proxy->setTransactionPHID(
PhabricatorPHID::generateNewPHID(
PhabricatorApplicationTransactionPHIDTypeTransaction::TYPECONST,
@@ -175,11 +174,6 @@
return $this;
}
- public function getCommentID() {
- return $this->proxy->getLegacyCommentID();
- }
-
-
/* -( PhabricatorMarkupInterface Implementation )-------------------------- */
@@ -202,7 +196,7 @@
public function shouldUseMarkupCache($field) {
// Only cache submitted comments.
- return ($this->getID() && $this->getCommentID());
+ return ($this->getID() && !$this->isDraft());
}
}

File Metadata

Mime Type
text/plain
Expires
Sun, May 12, 2:33 AM (2 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6287212
Default Alt Text
D8240.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility