Page MenuHomePhabricator

D13776.id.diff
No OneTemporary

D13776.id.diff

diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php
--- a/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php
+++ b/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php
@@ -3,18 +3,12 @@
final class PhabricatorXHPASTViewFrameController
extends PhabricatorXHPASTViewController {
- private $id;
-
public function shouldAllowPublic() {
return true;
}
- public function willProcessRequest(array $data) {
- $this->id = $data['id'];
- }
-
- public function processRequest() {
- $id = $this->id;
+ public function handleRequest(AphrontRequest $request) {
+ $id = $request->getURIData('id');
return $this->buildStandardPageResponse(
phutil_tag(
diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewFramesetController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewFramesetController.php
--- a/src/applications/phpast/controller/PhabricatorXHPASTViewFramesetController.php
+++ b/src/applications/phpast/controller/PhabricatorXHPASTViewFramesetController.php
@@ -3,18 +3,12 @@
final class PhabricatorXHPASTViewFramesetController
extends PhabricatorXHPASTViewController {
- private $id;
-
public function shouldAllowPublic() {
return true;
}
- public function willProcessRequest(array $data) {
- $this->id = $data['id'];
- }
-
- public function processRequest() {
- $id = $this->id;
+ public function handleRequest(AphrontRequest $request) {
+ $id = $request->getURIData('id');
$response = new AphrontWebpageResponse();
$response->setFrameable(true);
diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewInputController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewInputController.php
--- a/src/applications/phpast/controller/PhabricatorXHPASTViewInputController.php
+++ b/src/applications/phpast/controller/PhabricatorXHPASTViewInputController.php
@@ -3,7 +3,7 @@
final class PhabricatorXHPASTViewInputController
extends PhabricatorXHPASTViewPanelController {
- public function processRequest() {
+ public function handleRequest(AphrontRequest $request) {
$input = $this->getStorageTree()->getInput();
return $this->buildXHPASTViewPanelResponse($input);
}
diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewRunController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewRunController.php
--- a/src/applications/phpast/controller/PhabricatorXHPASTViewRunController.php
+++ b/src/applications/phpast/controller/PhabricatorXHPASTViewRunController.php
@@ -3,10 +3,8 @@
final class PhabricatorXHPASTViewRunController
extends PhabricatorXHPASTViewController {
- public function processRequest() {
-
- $request = $this->getRequest();
- $user = $request->getUser();
+ public function handleRequest(AphrontRequest $request) {
+ $viewer = $this->getViewer();
if ($request->isFormPost()) {
$source = $request->getStr('source');
@@ -24,7 +22,7 @@
$storage_tree = new PhabricatorXHPASTViewParseTree();
$storage_tree->setInput($source);
$storage_tree->setStdout($stdout);
- $storage_tree->setAuthorPHID($user->getPHID());
+ $storage_tree->setAuthorPHID($viewer->getPHID());
$storage_tree->save();
return id(new AphrontRedirectResponse())
@@ -32,7 +30,7 @@
}
$form = id(new AphrontFormView())
- ->setUser($user)
+ ->setUser($viewer)
->appendChild(
id(new AphrontFormTextAreaControl())
->setLabel(pht('Source'))
diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewStreamController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewStreamController.php
--- a/src/applications/phpast/controller/PhabricatorXHPASTViewStreamController.php
+++ b/src/applications/phpast/controller/PhabricatorXHPASTViewStreamController.php
@@ -3,7 +3,7 @@
final class PhabricatorXHPASTViewStreamController
extends PhabricatorXHPASTViewPanelController {
- public function processRequest() {
+ public function handleRequest(AphrontRequest $request) {
$storage = $this->getStorageTree();
$input = $storage->getInput();
$stdout = $storage->getStdout();
diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewTreeController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewTreeController.php
--- a/src/applications/phpast/controller/PhabricatorXHPASTViewTreeController.php
+++ b/src/applications/phpast/controller/PhabricatorXHPASTViewTreeController.php
@@ -7,7 +7,7 @@
return true;
}
- public function processRequest() {
+ public function handleRequest(AphrontRequest $request) {
$storage = $this->getStorageTree();
$input = $storage->getInput();
$stdout = $storage->getStdout();

File Metadata

Mime Type
text/plain
Expires
Fri, May 10, 4:49 AM (1 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6281600
Default Alt Text
D13776.id.diff (4 KB)

Event Timeline