Page MenuHomePhabricator
Files F13180520

D8690.diff
No OneTemporary
Actions

D8690.diff
View Options

diff --git a/src/workflow/ArcanistWhichWorkflow.php b/src/workflow/ArcanistWhichWorkflow.php
--- a/src/workflow/ArcanistWhichWorkflow.php
+++ b/src/workflow/ArcanistWhichWorkflow.php
@@ -43,9 +43,6 @@
public function getArguments() {
return array(
- 'any-author' => array(
- 'help' => "Show revisions by any author, not just you.",
- ),
'any-status' => array(
'help' => "Show committed and abandoned revisions.",
),
@@ -138,13 +135,9 @@
echo $commits."\n\n\n";
}
- $any_author = $this->getArgument('any-author');
$any_status = $this->getArgument('any-status');
$query = array(
- 'authors' => $any_author
- ? null
- : array($this->getUserPHID()),
'status' => $any_status
? 'status-any'
: 'status-open',
@@ -169,8 +162,34 @@
"working copy, a new revision will be **created** if you run ".
"'arc diff{$arg}'.\n\n"));
} else {
+ $other_author_phids = array();
foreach ($revisions as $revision) {
- echo ' D'.$revision['id'].' '.$revision['title']."\n";
+ if ($revision['authorPHID'] != $this->getUserPHID()) {
+ $other_author_phids[] = $revision['authorPHID'];
+ }
+ }
+
+ $other_authors = array();
+ if ($other_author_phids) {
+ $other_authors = $this->getConduit()->callMethodSynchronous(
+ 'user.query',
+ array(
+ 'phids' => $other_author_phids,
+ ));
+ $other_authors = ipull($other_authors, 'userName', 'phid');
+ }
+
+ foreach ($revisions as $revision) {
+ $title = $revision['title'];
+ $monogram = 'D'.$revision['id'];
+
+ if ($revision['authorPHID'] != $this->getUserPHID()) {
+ $author = $other_authors[$revision['authorPHID']];
+ echo pht(" %s (%s) %s\n", $monogram, $author, $title);
+ } else {
+ echo pht(" %s %s\n", $monogram, $title);
+ }
+
echo ' Reason: '.$revision['why']."\n";
echo "\n";
}

File Metadata

Mime Type
text/plain
Expires
Fri, May 10, 12:35 AM (3 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6281051
Default Alt Text
D8690.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility