Page MenuHomePhabricator

D12198.id32755.diff
No OneTemporary

D12198.id32755.diff

diff --git a/src/lint/linter/ArcanistESLintLinter.php b/src/lint/linter/ArcanistESLintLinter.php
--- a/src/lint/linter/ArcanistESLintLinter.php
+++ b/src/lint/linter/ArcanistESLintLinter.php
@@ -14,8 +14,18 @@
return pht('ESLint is a linter for JavaScript source files.');
}
+ public function getVersion() {
+ $output = exec('eslint --version');
+
+ if (strpos($output, 'command not found') !== false) {
+ return false;
+ }
+
+ return $output;
+ }
+
public function getLinterName() {
- return 'ESLint';
+ return 'ESLINT';
}
public function getLinterConfigurationName() {
@@ -27,11 +37,7 @@
}
public function getInstallInstructions() {
- return pht('Install ESLint using `npm install -g eslint`.');
- }
-
- protected function canCustomizeLintSeverities() {
- return true;
+ return pht('Install ESLint using `%s`.', 'npm install -g eslint');
}
protected function parseLinterOutput($path, $err, $stdout, $stderr) {

File Metadata

Mime Type
text/plain
Expires
Thu, May 9, 11:03 PM (3 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6279884
Default Alt Text
D12198.id32755.diff (1 KB)

Event Timeline