Page MenuHomePhabricator
Files F13179823

D11431.diff
No OneTemporary
Actions

D11431.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -8,10 +8,10 @@
return array(
'names' => array(
'core.pkg.css' => '8d1c0f87',
- 'core.pkg.js' => '7923c2e6',
+ 'core.pkg.js' => 'd60876a7',
'darkconsole.pkg.js' => '8ab24e01',
'differential.pkg.css' => '8af45893',
- 'differential.pkg.js' => 'dad3622f',
+ 'differential.pkg.js' => 'f437e70e',
'diffusion.pkg.css' => '591664fa',
'diffusion.pkg.js' => 'bfc0737b',
'maniphest.pkg.css' => 'e34dfbec',
@@ -166,10 +166,10 @@
'rsrc/externals/javelin/core/__tests__/install.js' => 'c432ee85',
'rsrc/externals/javelin/core/__tests__/stratcom.js' => '88bf7313',
'rsrc/externals/javelin/core/__tests__/util.js' => 'e251703d',
- 'rsrc/externals/javelin/core/init.js' => '76e1fd61',
- 'rsrc/externals/javelin/core/init_node.js' => '7212f324',
+ 'rsrc/externals/javelin/core/init.js' => '8c4e8f8b',
+ 'rsrc/externals/javelin/core/init_node.js' => '77350e4d',
'rsrc/externals/javelin/core/install.js' => '05270951',
- 'rsrc/externals/javelin/core/util.js' => 'bdcfee9e',
+ 'rsrc/externals/javelin/core/util.js' => '93cc50d6',
'rsrc/externals/javelin/docs/Base.js' => '74676256',
'rsrc/externals/javelin/docs/onload.js' => 'e819c479',
'rsrc/externals/javelin/ext/fx/Color.js' => '7e41274a',
@@ -186,11 +186,11 @@
'rsrc/externals/javelin/ext/view/ViewRenderer.js' => '6c2b09a2',
'rsrc/externals/javelin/ext/view/ViewVisitor.js' => 'efe49472',
'rsrc/externals/javelin/ext/view/__tests__/HTMLView.js' => 'f92d7bcb',
- 'rsrc/externals/javelin/ext/view/__tests__/View.js' => 'bda69c40',
+ 'rsrc/externals/javelin/ext/view/__tests__/View.js' => '6450b38b',
'rsrc/externals/javelin/ext/view/__tests__/ViewInterpreter.js' => '7a94d6a5',
'rsrc/externals/javelin/ext/view/__tests__/ViewRenderer.js' => '6ea96ac9',
'rsrc/externals/javelin/lib/Cookie.js' => '6b3dcf44',
- 'rsrc/externals/javelin/lib/DOM.js' => 'c4569c05',
+ 'rsrc/externals/javelin/lib/DOM.js' => 'c8fd8db2',
'rsrc/externals/javelin/lib/History.js' => 'c60f4327',
'rsrc/externals/javelin/lib/JSON.js' => '69adf288',
'rsrc/externals/javelin/lib/Leader.js' => '9330f91b',
@@ -215,7 +215,7 @@
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js' => '503e17fd',
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js' => '8b3fd187',
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js' => '54f314a0',
- 'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js' => 'e3b841c8',
+ 'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js' => '2818f5ce',
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js' => '316b8fa1',
'rsrc/externals/raphael/g.raphael.js' => '40dde778',
'rsrc/externals/raphael/g.raphael.line.js' => '40da039e',
@@ -362,7 +362,7 @@
'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d',
'rsrc/js/application/differential/behavior-comment-preview.js' => '6932def3',
'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1',
- 'rsrc/js/application/differential/behavior-dropdown-menus.js' => '3bc14668',
+ 'rsrc/js/application/differential/behavior-dropdown-menus.js' => 'e33d4bc5',
'rsrc/js/application/differential/behavior-edit-inline-comments.js' => '00861799',
'rsrc/js/application/differential/behavior-keyboard-nav.js' => '2c426492',
'rsrc/js/application/differential/behavior-populate.js' => 'bdb3e4d0',
@@ -410,7 +410,7 @@
'rsrc/js/application/projects/behavior-project-create.js' => '065227cc',
'rsrc/js/application/projects/behavior-reorder-columns.js' => 'e1d25dfb',
'rsrc/js/application/releeph/releeph-preview-branch.js' => 'b2b4fbaf',
- 'rsrc/js/application/releeph/releeph-request-state-change.js' => 'ab836011',
+ 'rsrc/js/application/releeph/releeph-request-state-change.js' => '3a1a4060',
'rsrc/js/application/releeph/releeph-request-typeahead.js' => 'de2e896f',
'rsrc/js/application/repository/repository-crossreference.js' => 'f9539603',
'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08',
@@ -444,7 +444,7 @@
'rsrc/js/core/ShapedRequest.js' => '7cbe244b',
'rsrc/js/core/TextAreaUtils.js' => '5c93c52c',
'rsrc/js/core/Title.js' => '5c1c758c',
- 'rsrc/js/core/ToolTip.js' => '031d4411',
+ 'rsrc/js/core/ToolTip.js' => '1d298e3a',
'rsrc/js/core/behavior-active-nav.js' => 'e379b58e',
'rsrc/js/core/behavior-audio-source.js' => '59b251eb',
'rsrc/js/core/behavior-autofocus.js' => '7319e029',
@@ -564,7 +564,7 @@
'javelin-behavior-differential-add-reviewers-and-ccs' => 'e10f8e18',
'javelin-behavior-differential-comment-jump' => '4fdb476d',
'javelin-behavior-differential-diff-radios' => 'e1ff79b1',
- 'javelin-behavior-differential-dropdown-menus' => '3bc14668',
+ 'javelin-behavior-differential-dropdown-menus' => 'e33d4bc5',
'javelin-behavior-differential-edit-inline-comments' => '00861799',
'javelin-behavior-differential-feedback-preview' => '6932def3',
'javelin-behavior-differential-keyboard-navigation' => '2c426492',
@@ -635,7 +635,7 @@
'javelin-behavior-project-create' => '065227cc',
'javelin-behavior-refresh-csrf' => '7814b593',
'javelin-behavior-releeph-preview-branch' => 'b2b4fbaf',
- 'javelin-behavior-releeph-request-state-change' => 'ab836011',
+ 'javelin-behavior-releeph-request-state-change' => '3a1a4060',
'javelin-behavior-releeph-request-typeahead' => 'de2e896f',
'javelin-behavior-remarkup-preview' => 'f7379f45',
'javelin-behavior-reorder-applications' => '76b9fc3e',
@@ -652,7 +652,7 @@
'javelin-color' => '7e41274a',
'javelin-cookie' => '6b3dcf44',
'javelin-diffusion-locate-file-source' => 'b42eddc7',
- 'javelin-dom' => 'c4569c05',
+ 'javelin-dom' => 'c8fd8db2',
'javelin-dynval' => 'f6555212',
'javelin-event' => '85ea0626',
'javelin-fx' => '54b612ba',
@@ -660,7 +660,7 @@
'javelin-install' => '05270951',
'javelin-json' => '69adf288',
'javelin-leader' => '9330f91b',
- 'javelin-magical-init' => '76e1fd61',
+ 'javelin-magical-init' => '8c4e8f8b',
'javelin-mask' => '8a41885b',
'javelin-reactor' => '2b8de964',
'javelin-reactor-dom' => 'c90a04fc',
@@ -677,10 +677,10 @@
'javelin-typeahead-normalizer' => '6f7a9da8',
'javelin-typeahead-ondemand-source' => '8b3fd187',
'javelin-typeahead-preloaded-source' => '54f314a0',
- 'javelin-typeahead-source' => 'e3b841c8',
+ 'javelin-typeahead-source' => '2818f5ce',
'javelin-typeahead-static-source' => '316b8fa1',
'javelin-uri' => '6eff08aa',
- 'javelin-util' => 'bdcfee9e',
+ 'javelin-util' => '93cc50d6',
'javelin-vector' => 'cc1bd0b0',
'javelin-view' => '0f764c35',
'javelin-view-html' => 'fe287620',
@@ -738,7 +738,7 @@
'phabricator-standard-page-view' => '2c96cfb5',
'phabricator-textareautils' => '5c93c52c',
'phabricator-title' => '5c1c758c',
- 'phabricator-tooltip' => '031d4411',
+ 'phabricator-tooltip' => '1d298e3a',
'phabricator-transaction-view-css' => '5d0cae25',
'phabricator-ui-example-css' => '528b19de',
'phabricator-uiexample-javelin-view' => 'd4a14807',
@@ -834,12 +834,6 @@
'029a133d' => array(
'aphront-dialog-view-css',
),
- '031d4411' => array(
- 'javelin-install',
- 'javelin-util',
- 'javelin-dom',
- 'javelin-vector',
- ),
'03d6ed07' => array(
'javelin-behavior',
'javelin-stratcom',
@@ -944,6 +938,12 @@
'javelin-util',
'phabricator-keyboard-shortcut-manager',
),
+ '1d298e3a' => array(
+ 'javelin-install',
+ 'javelin-util',
+ 'javelin-dom',
+ 'javelin-vector',
+ ),
'1def2711' => array(
'javelin-install',
'javelin-dom',
@@ -956,6 +956,12 @@
'javelin-workflow',
'javelin-util',
),
+ '2818f5ce' => array(
+ 'javelin-install',
+ 'javelin-util',
+ 'javelin-dom',
+ 'javelin-typeahead-normalizer',
+ ),
'2926fff2' => array(
'javelin-behavior',
'javelin-dom',
@@ -1023,6 +1029,14 @@
'javelin-json',
'phabricator-prefab',
),
+ '3a1a4060' => array(
+ 'javelin-behavior',
+ 'javelin-dom',
+ 'javelin-stratcom',
+ 'javelin-workflow',
+ 'javelin-util',
+ 'phabricator-keyboard-shortcut',
+ ),
'3ab51e2c' => array(
'javelin-behavior',
'javelin-behavior-device',
@@ -1031,18 +1045,6 @@
'javelin-dom',
'javelin-magical-init',
),
- '3bc14668' => array(
- 'javelin-behavior',
- 'javelin-dom',
- 'javelin-util',
- 'javelin-stratcom',
- 'javelin-workflow',
- 'phuix-dropdown-menu',
- 'phuix-action-list-view',
- 'phuix-action-view',
- 'phabricator-phtize',
- 'changeset-view-manager',
- ),
'3d51a746' => array(
'javelin-behavior',
'javelin-dom',
@@ -1560,14 +1562,6 @@
'javelin-util',
'phabricator-prefab',
),
- 'ab836011' => array(
- 'javelin-behavior',
- 'javelin-dom',
- 'javelin-stratcom',
- 'javelin-workflow',
- 'javelin-util',
- 'phabricator-keyboard-shortcut',
- ),
'ad7a69ca' => array(
'javelin-install',
'javelin-util',
@@ -1656,13 +1650,6 @@
'javelin-util',
'phabricator-shaped-request',
),
- 'c4569c05' => array(
- 'javelin-magical-init',
- 'javelin-install',
- 'javelin-util',
- 'javelin-vector',
- 'javelin-stratcom',
- ),
'c51ae228' => array(
'javelin-behavior',
'javelin-util',
@@ -1676,6 +1663,13 @@
'javelin-uri',
'javelin-util',
),
+ 'c8fd8db2' => array(
+ 'javelin-magical-init',
+ 'javelin-install',
+ 'javelin-util',
+ 'javelin-vector',
+ 'javelin-stratcom',
+ ),
'c90a04fc' => array(
'javelin-dom',
'javelin-dynval',
@@ -1794,6 +1788,18 @@
'javelin-workflow',
'javelin-vector',
),
+ 'e33d4bc5' => array(
+ 'javelin-behavior',
+ 'javelin-dom',
+ 'javelin-util',
+ 'javelin-stratcom',
+ 'javelin-workflow',
+ 'phuix-dropdown-menu',
+ 'phuix-action-list-view',
+ 'phuix-action-view',
+ 'phabricator-phtize',
+ 'changeset-view-manager',
+ ),
'e379b58e' => array(
'javelin-behavior',
'javelin-stratcom',
@@ -1801,12 +1807,6 @@
'javelin-dom',
'javelin-uri',
),
- 'e3b841c8' => array(
- 'javelin-install',
- 'javelin-util',
- 'javelin-dom',
- 'javelin-typeahead-normalizer',
- ),
'e4cc26b3' => array(
'javelin-behavior',
'javelin-dom',
diff --git a/support/aphlict/server/aphlict_server.js b/support/aphlict/server/aphlict_server.js
--- a/support/aphlict/server/aphlict_server.js
+++ b/support/aphlict/server/aphlict_server.js
@@ -22,10 +22,10 @@
var arg = argv[ii];
var matches = arg.match(/^--([^=]+)=(.*)$/);
if (!matches) {
- throw new Error("Unknown argument '" + arg + "'!");
+ throw new Error('Unknown argument "' + arg + '"!');
}
if (!(matches[1] in config)) {
- throw new Error("Unknown argument '" + matches[1] + "'!");
+ throw new Error('Unknown argument "' + matches[1] + '"!');
}
config[matches[1]] = matches[2];
}
diff --git a/webroot/rsrc/externals/javelin/core/init.js b/webroot/rsrc/externals/javelin/core/init.js
--- a/webroot/rsrc/externals/javelin/core/init.js
+++ b/webroot/rsrc/externals/javelin/core/init.js
@@ -208,9 +208,9 @@
}, true);
} else {
var ready =
- "if (this.readyState == 'complete') {" +
- "JX.__rawEventQueue({type: 'domready'});" +
- "}";
+ 'if (this.readyState == "complete") {' +
+ 'JX.__rawEventQueue({type: "domready"});' +
+ '}';
// NOTE: Don't write a 'src' attribute, because "javascript:void(0)" causes
// a mixed content warning in IE8 if the page is served over SSL.
diff --git a/webroot/rsrc/externals/javelin/core/util.js b/webroot/rsrc/externals/javelin/core/util.js
--- a/webroot/rsrc/externals/javelin/core/util.js
+++ b/webroot/rsrc/externals/javelin/core/util.js
@@ -319,7 +319,7 @@
if (recent_alerts.length >= 3 &&
(recent_alerts[recent_alerts.length - 1] - recent_alerts[0]) < 5000) {
- if (window.confirm(msg + "\n\nLots of alert()s recently. Kill them?")) {
+ if (window.confirm(msg + '\n\nLots of alert()s recently. Kill them?')) {
window.alert = JX.bag;
}
} else {
diff --git a/webroot/rsrc/externals/javelin/ext/view/__tests__/View.js b/webroot/rsrc/externals/javelin/ext/view/__tests__/View.js
--- a/webroot/rsrc/externals/javelin/ext/view/__tests__/View.js
+++ b/webroot/rsrc/externals/javelin/ext/view/__tests__/View.js
@@ -29,7 +29,7 @@
var t = new JX.TestView(
'',
{},
- [new JX.TestView('Hey', {id: "child"}, [])]
+ [new JX.TestView('Hey', {id: 'child'}, [])]
);
var result = JX.ViewRenderer.render(t);
expect(JX.DOM.scry(result, 'span').length).toBe(1);
diff --git a/webroot/rsrc/externals/javelin/lib/DOM.js b/webroot/rsrc/externals/javelin/lib/DOM.js
--- a/webroot/rsrc/externals/javelin/lib/DOM.js
+++ b/webroot/rsrc/externals/javelin/lib/DOM.js
@@ -46,14 +46,14 @@
if (__DEV__) {
if (node && (node.id != id)) {
JX.$E(
- 'JX.$("'+id+'"): '+
+ 'JX.$(\''+id+'\'): '+
'document.getElementById() returned an element without the '+
'correct ID. This usually means that the element you are trying '+
'to select is being masked by a form with the same value in its '+
'"name" attribute.');
}
}
- JX.$E("JX.$('" + id + "') call matched no nodes.");
+ JX.$E('JX.$(\'' + id + '\') call matched no nodes.');
}
return node;
diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js
--- a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js
+++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js
@@ -187,8 +187,8 @@
for (var k in {name : 1, id : 1, display : 1, uri : 1}) {
if (!(k in obj)) {
throw new Error(
- "JX.TypeaheadSource.addResult(): " +
- "result must have properties 'name', 'id', 'uri' and 'display'.");
+ 'JX.TypeaheadSource.addResult(): result must have ' +
+ 'properties \'name\', \'id\', \'uri\' and \'display\'.');
}
}
}
diff --git a/webroot/rsrc/js/application/differential/behavior-dropdown-menus.js b/webroot/rsrc/js/application/differential/behavior-dropdown-menus.js
--- a/webroot/rsrc/js/application/differential/behavior-dropdown-menus.js
+++ b/webroot/rsrc/js/application/differential/behavior-dropdown-menus.js
@@ -218,7 +218,7 @@
visible_item
.setDisabled(true)
.setIcon('fa-expand')
- .setName(pht("Can't Toggle Unloaded File"));
+ .setName(pht('Can\'t Toggle Unloaded File'));
var diffs = JX.DOM.scry(
JX.$(data.containerID),
'table',
diff --git a/webroot/rsrc/js/application/releeph/releeph-request-state-change.js b/webroot/rsrc/js/application/releeph/releeph-request-state-change.js
--- a/webroot/rsrc/js/application/releeph/releeph-request-state-change.js
+++ b/webroot/rsrc/js/application/releeph/releeph-request-state-change.js
@@ -91,7 +91,7 @@
new JX.KeyboardShortcut(
['g', 'return'],
- "Open selected request's page in a new tab.")
+ 'Open selected request\'s page in a new tab.')
.setHandler(function() {
keynavNavigateToRequestPage();
})
diff --git a/webroot/rsrc/js/core/ToolTip.js b/webroot/rsrc/js/core/ToolTip.js
--- a/webroot/rsrc/js/core/ToolTip.js
+++ b/webroot/rsrc/js/core/ToolTip.js
@@ -22,8 +22,8 @@
break;
default:
JX.$E(
- "Only alignments 'N' (north), 'E' (east), 'S' (south), " +
- "and 'W' (west) are supported."
+ 'Only alignments "N" (north), "E" (east), "S" (south), ' +
+ 'and "W" (west) are supported.'
);
break;
}

File Metadata

Mime Type
text/plain
Expires
Thu, May 9, 9:28 PM (3 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6277986
Default Alt Text
D11431.diff (16 KB)

Event Timeline

Phabricator · Built by Phacility