Page MenuHomePhabricator

D19290.diff
No OneTemporary

D19290.diff

diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -7,7 +7,6 @@
private $isCloseByCommit;
private $repositoryPHIDOverride = false;
private $didExpandInlineState = false;
- private $hasReviewTransaction = false;
private $affectedPaths;
private $firstBroadcast = false;
private $wasBroadcasting;
@@ -128,13 +127,6 @@
// built it for us so we don't need to expand it again.
$this->didExpandInlineState = true;
break;
- case DifferentialRevisionAcceptTransaction::TRANSACTIONTYPE:
- case DifferentialRevisionRejectTransaction::TRANSACTIONTYPE:
- case DifferentialRevisionResignTransaction::TRANSACTIONTYPE:
- // If we have a review transaction, we'll skip marking the user
- // as "Commented" later. This should get cleaner after T10967.
- $this->hasReviewTransaction = true;
- break;
case DifferentialRevisionPlanChangesTransaction::TRANSACTIONTYPE:
if ($xaction->getMetadataValue('draft.demote')) {
$this->isDraftDemotion = true;

File Metadata

Mime Type
text/plain
Expires
Thu, May 9, 9:15 PM (1 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6277718
Default Alt Text
D19290.diff (1 KB)

Event Timeline