Page MenuHomePhabricator

D21760.id51880.diff
No OneTemporary

D21760.id51880.diff

diff --git a/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php b/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
--- a/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
+++ b/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
@@ -141,9 +141,7 @@
}
}
- // Find the smallest "new" changeset ID. We'll consider everything
- // larger than this to be "newer", and everything smaller to be "older".
- $first_new_id = min(mpull($new, 'getID'));
+ $new_id_map = mpull($new, null, 'getID');
$results = array();
foreach ($inlines as $inline) {
@@ -163,7 +161,7 @@
$target_id = null;
- if ($changeset_id >= $first_new_id) {
+ if (isset($new_id_map[$changeset_id])) {
$name_map = $name_map_new;
$is_new = true;
} else {

File Metadata

Mime Type
text/plain
Expires
Thu, May 9, 8:58 PM (3 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6277399
Default Alt Text
D21760.id51880.diff (899 B)

Event Timeline