Page MenuHomePhabricator

D12921.diff
No OneTemporary

D12921.diff

diff --git a/src/lint/linter/ArcanistXHPASTLinter.php b/src/lint/linter/ArcanistXHPASTLinter.php
--- a/src/lint/linter/ArcanistXHPASTLinter.php
+++ b/src/lint/linter/ArcanistXHPASTLinter.php
@@ -4133,7 +4133,7 @@
$function_name,
self::LINT_ALIAS_FUNCTION,
pht('Alias functions should be avoided.'),
- $aliases[$function_name->getConcreteString()]);
+ $aliases[phutil_utf8_strtolower($function_name->getConcreteString())]);
}
}
diff --git a/src/lint/linter/__tests__/xhpast/alias-functions.lint-test b/src/lint/linter/__tests__/xhpast/alias-functions.lint-test
--- a/src/lint/linter/__tests__/xhpast/alias-functions.lint-test
+++ b/src/lint/linter/__tests__/xhpast/alias-functions.lint-test
@@ -3,12 +3,15 @@
$x = array();
sizeof($x);
die();
+sizeOf($x);
~~~~~~~~~~
advice:4:1
advice:5:1
+advice:6:1
~~~~~~~~~~
<?php
$x = array();
count($x);
exit();
+count($x);

File Metadata

Mime Type
text/plain
Expires
May 9 2024, 8:04 PM (5 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6276321
Default Alt Text
D12921.diff (926 B)

Event Timeline