Page MenuHomePhabricator

D20584.diff
No OneTemporary

D20584.diff

diff --git a/src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php b/src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
--- a/src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
+++ b/src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
@@ -62,6 +62,23 @@
->setDisabled(!$can_edit)
->setWorkflow(!$can_edit));
+ $drequest = DiffusionRequest::newFromDictionary(
+ array(
+ 'user' => $viewer,
+ 'repository' => $repository,
+ ));
+
+ $view_uri = $drequest->generateURI(
+ array(
+ 'action' => 'branches',
+ ));
+
+ $action_list->addAction(
+ id(new PhabricatorActionView())
+ ->setIcon('fa-code-fork')
+ ->setName(pht('View Branches'))
+ ->setHref($view_uri));
+
return $this->newCurtainView()
->setActionList($action_list);
}
@@ -111,98 +128,6 @@
$content[] = $this->newBox(pht('Branches'), $view);
- if (!$repository->isImporting()) {
- $request = $this->getRequest();
- $pager = id(new PHUIPagerView())
- ->readFromRequest($request);
-
- $params = array(
- 'offset' => $pager->getOffset(),
- 'limit' => $pager->getPageSize() + 1,
- 'repository' => $repository->getID(),
- );
-
- $branches = id(new ConduitCall('diffusion.branchquery', $params))
- ->setUser($viewer)
- ->execute();
- $branches = DiffusionRepositoryRef::loadAllFromDictionaries($branches);
- $branches = $pager->sliceResults($branches);
- $can_close_branches = ($repository->isHg());
-
- $publisher = $repository->newPublisher();
-
- $rows = array();
- foreach ($branches as $branch) {
- $branch_name = $branch->getShortName();
- $permanent = $publisher->shouldPublishRef($branch);
-
- $default = $repository->getDefaultBranch();
- $icon = null;
- if ($default == $branch->getShortName()) {
- $icon = id(new PHUIIconView())
- ->setIcon('fa-code-fork');
- }
-
- $fields = $branch->getRawFields();
- $closed = idx($fields, 'closed');
- if ($closed) {
- $status = pht('Closed');
- } else {
- $status = pht('Open');
- }
-
- if ($publishing_disabled) {
- $permanent_status = pht('Publishing Disabled');
- } else {
- if ($permanent) {
- $permanent_status = pht('Permanent');
- } else {
- $permanent_status = pht('Not Permanent');
- }
- }
-
- $rows[] = array(
- $icon,
- $branch_name,
- $status,
- $permanent_status,
- );
- }
- $branch_table = new AphrontTableView($rows);
- $branch_table->setHeaders(
- array(
- '',
- pht('Branch'),
- pht('Status'),
- pht('Permanent'),
- ));
- $branch_table->setColumnClasses(
- array(
- '',
- 'pri',
- 'narrow',
- 'wide',
- ));
- $branch_table->setColumnVisibility(
- array(
- true,
- true,
- $can_close_branches,
- true,
- ));
-
- $box = $this->newBox(pht('Branch Status'), $branch_table);
- $box->setPager($pager);
- $content[] = $box;
- } else {
- $content[] = id(new PHUIInfoView())
- ->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
- ->appendChild(
- pht(
- 'Branch status is unavailable while the repository is still '.
- 'importing.'));
- }
-
return $content;
}

File Metadata

Mime Type
text/plain
Expires
Thu, May 9, 7:15 PM (3 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6275507
Default Alt Text
D20584.diff (3 KB)

Event Timeline