Page MenuHomePhabricator
Files F13176099

D20115.id.diff
No OneTemporary
Actions

D20115.id.diff
View Options

diff --git a/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php b/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
--- a/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
+++ b/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
@@ -84,6 +84,24 @@
$issue->addPhabricatorConfig($key);
}
}
+
+
+ if (PhabricatorEnv::getEnvConfig('feed.http-hooks')) {
+ $this->newIssue('config.deprecated.feed.http-hooks')
+ ->setShortName(pht('Feed Hooks Deprecated'))
+ ->setName(pht('Migrate From "feed.http-hooks" to Webhooks'))
+ ->addPhabricatorConfig('feed.http-hooks')
+ ->setMessage(
+ pht(
+ 'The "feed.http-hooks" option is deprecated in favor of '.
+ 'Webhooks. This option will be removed in a future version '.
+ 'of Phabricator.'.
+ "\n\n".
+ 'You can configure Webhooks in Herald.'.
+ "\n\n".
+ 'To resolve this issue, remove all URIs from "feed.http-hooks".'));
+ }
+
}
/**
diff --git a/src/applications/feed/config/PhabricatorFeedConfigOptions.php b/src/applications/feed/config/PhabricatorFeedConfigOptions.php
--- a/src/applications/feed/config/PhabricatorFeedConfigOptions.php
+++ b/src/applications/feed/config/PhabricatorFeedConfigOptions.php
@@ -20,22 +20,22 @@
}
public function getOptions() {
+ $hooks_help = $this->deformat(pht(<<<EODOC
+IMPORTANT: Feed hooks are deprecated and have been replaced by Webhooks.
+
+You can configure Webhooks in Herald. This configuration option will be removed
+in a future version of Phabricator.
+
+(This legacy option may be configured with a list of URIs; feed stories will
+send to these URIs.)
+EODOC
+ ));
+
return array(
$this->newOption('feed.http-hooks', 'list<string>', array())
->setLocked(true)
- ->setSummary(pht('POST notifications of feed events.'))
- ->setDescription(
- pht(
- "If you set this to a list of HTTP URIs, when a feed story is ".
- "published a task will be created for each URI that posts the ".
- "story data to the URI. Daemons automagically retry failures 100 ".
- "times, waiting `\$fail_count * 60s` between each subsequent ".
- "failure. Be sure to keep the daemon console (`%s`) open ".
- "while developing and testing your end points. You may need to".
- "restart your daemons to start sending HTTP requests.\n\n".
- "NOTE: URIs are not validated, the URI must return HTTP status ".
- "200 within 30 seconds, and no permission checks are performed.",
- '/daemon/')),
+ ->setSummary(pht('Deprecated.'))
+ ->setDescription($hooks_help),
);
}

File Metadata

Mime Type
text/plain
Expires
Thu, May 9, 10:26 AM (3 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6274637
Default Alt Text
D20115.id.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility