Page MenuHomePhabricator
Files F13173553

D11233.id26976.diff
No OneTemporary
Actions

D11233.id26976.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -1860,6 +1860,7 @@
'PhabricatorLegalpadConfigOptions' => 'applications/legalpad/config/PhabricatorLegalpadConfigOptions.php',
'PhabricatorLegalpadDocumentPHIDType' => 'applications/legalpad/phid/PhabricatorLegalpadDocumentPHIDType.php',
'PhabricatorLegalpadSignaturePolicyRule' => 'applications/policy/rule/PhabricatorLegalpadSignaturePolicyRule.php',
+ 'PhabricatorLibraryTestCase' => '__tests__/PhabricatorLibraryTestCase.php',
'PhabricatorLipsumArtist' => 'applications/lipsum/image/PhabricatorLipsumArtist.php',
'PhabricatorLipsumGenerateWorkflow' => 'applications/lipsum/management/PhabricatorLipsumGenerateWorkflow.php',
'PhabricatorLipsumManagementWorkflow' => 'applications/lipsum/management/PhabricatorLipsumManagementWorkflow.php',
@@ -5057,6 +5058,7 @@
'PhabricatorLegalpadConfigOptions' => 'PhabricatorApplicationConfigOptions',
'PhabricatorLegalpadDocumentPHIDType' => 'PhabricatorPHIDType',
'PhabricatorLegalpadSignaturePolicyRule' => 'PhabricatorPolicyRule',
+ 'PhabricatorLibraryTestCase' => 'PhutilLibraryTestCase',
'PhabricatorLipsumGenerateWorkflow' => 'PhabricatorLipsumManagementWorkflow',
'PhabricatorLipsumManagementWorkflow' => 'PhabricatorManagementWorkflow',
'PhabricatorLipsumMondrianArtist' => 'PhabricatorLipsumArtist',
diff --git a/src/__tests__/PhabricatorInfrastructureTestCase.php b/src/__tests__/PhabricatorInfrastructureTestCase.php
--- a/src/__tests__/PhabricatorInfrastructureTestCase.php
+++ b/src/__tests__/PhabricatorInfrastructureTestCase.php
@@ -8,38 +8,6 @@
);
}
- /**
- * This is more of an acceptance test case instead of a unit test. It verifies
- * that all symbols can be loaded correctly. It can catch problems like
- * missing methods in descendants of abstract base classes.
- */
- public function testEverythingImplemented() {
- id(new PhutilSymbolLoader())->selectAndLoadSymbols();
- $this->assertTrue(true);
- }
-
- /**
- * This is more of an acceptance test case instead of a unit test. It verifies
- * that all the library map is up-to-date.
- */
- public function testLibraryMap() {
- $library = phutil_get_current_library_name();
- $root = phutil_get_library_root($library);
-
- $new_library_map = id(new PhutilLibraryMapBuilder($root))
- ->buildMap();
-
- $bootloader = PhutilBootloader::getInstance();
- $old_library_map = $bootloader->getLibraryMapWithoutExtensions($library);
- unset($old_library_map[PhutilLibraryMapBuilder::LIBRARY_MAP_VERSION_KEY]);
-
- $this->assertEqual(
- $new_library_map,
- $old_library_map,
- 'The library map does not appear to be up-to-date. Try '.
- 'rebuilding the map with `arc liberate`.');
- }
-
public function testApplicationsInstalled() {
$all = PhabricatorApplication::getAllApplications();
$installed = PhabricatorApplication::getAllInstalledApplications();
diff --git a/src/__tests__/PhabricatorLibraryTestCase.php b/src/__tests__/PhabricatorLibraryTestCase.php
new file mode 100644
--- /dev/null
+++ b/src/__tests__/PhabricatorLibraryTestCase.php
@@ -0,0 +1,3 @@
+<?php
+
+final class PhabricatorLibraryTestCase extends PhutilLibraryTestCase {}

File Metadata

Mime Type
text/plain
Expires
Wed, May 8, 8:09 PM (3 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6272784
Default Alt Text
D11233.id26976.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility