Page MenuHomePhabricator
Files F13173336

D7651.diff
No OneTemporary
Actions

D7651.diff
View Options

Index: src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterCowsay.php
===================================================================
--- src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterCowsay.php
+++ src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterCowsay.php
@@ -29,6 +29,7 @@
$tongue,
$cow);
+ $future->setTimeout(15);
$future->write($content);
list($err, $stdout, $stderr) = $future->resolve();
Index: src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterFiglet.php
===================================================================
--- src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterFiglet.php
+++ src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterFiglet.php
@@ -14,6 +14,7 @@
}
$future = id(new ExecFuture('figlet'))
+ ->setTimeout(15)
->write(trim($content, "\n"));
list($err, $stdout, $stderr) = $future->resolve();
Index: src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterGraphviz.php
===================================================================
--- src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterGraphviz.php
+++ src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterGraphviz.php
@@ -14,6 +14,7 @@
}
$future = id(new ExecFuture('dot -T%s', 'png'))
+ ->setTimeout(15)
->write(trim($content));
list($err, $stdout, $stderr) = $future->resolve();
@@ -21,7 +22,9 @@
if ($err) {
return $this->markupError(
pht(
- 'Execution of `dot` failed, check your syntax: %s', $stderr));
+ 'Execution of `dot` failed (#%d), check your syntax: %s',
+ $err,
+ $stderr));
}
$file = PhabricatorFile::buildFromFileDataOrHash(

File Metadata

Mime Type
text/plain
Expires
Wed, May 8, 7:16 PM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6272610
Default Alt Text
D7651.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility