Page MenuHomePhabricator
Differential D9922

Fix `arc` issues with non-English systems
AcceptedPublic
Actions

Authored by epriestley on Jul 13 2014, 6:43 PM.
Tags
None
Referenced Files
F14025100: D9922.diff
Thu, Nov 7, 2:27 PM
F14015539: D9922.diff
Sun, Nov 3, 8:47 PM
F14012696: D9922.id23816.diff
Fri, Nov 1, 3:23 PM
F14006238: D9922.diff
Mon, Oct 28, 3:53 AM
F13990674: D9922.id23839.diff
Tue, Oct 22, 5:25 AM
F13969014: D9922.id23816.diff
Thu, Oct 17, 12:00 AM
F13962909: D9922.diff
Tue, Oct 15, 12:55 PM
Unknown Object (File)
Wed, Oct 9, 4:22 PM
View All Files
Subscribers
epriestley
kugel-

Details

Reviewers
btrahan
Maniphest Tasks
T5554: arc fails with svn/git/hg non english locales
Summary

Fixes T5554. I can't get any of this stuff running in non-English, but I'll get some people reporting this issue to try it out.

Test Plan

seems to work idk??

Diff Detail

Repository
rARC Arcanist
Branch
lcall
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1702
Build 1703: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23816.Jul 13 2014, 6:43 PM
epriestley retitled this revision from to Fix `arc` issues with non-English systems.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5554: arc fails with svn/git/hg non english locales.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 13 2014, 6:43 PM
Harbormaster completed remote builds in B1684: Diff 23816.Jul 13 2014, 6:44 PM
epriestley updated this revision to Diff 23839.Jul 15 2014, 4:38 PM
  • Try using LANG instead.
  • Consolidate LANG logic from svn commit.
  • Fix an issue with passthru commands.
Harbormaster completed remote builds in B1699: Diff 23839.Jul 15 2014, 4:39 PM
epriestley updated this revision to Diff 23844.Jul 15 2014, 9:10 PM
  • Don't set LANG for passthru commands.
Harbormaster completed remote builds in B1702: Diff 23844.Jul 15 2014, 9:11 PM
btrahan accepted this revision.Jul 17 2014, 10:31 PM
btrahan edited edge metadata.

haha, <3 the testplan

This revision is now accepted and ready to land.Jul 17 2014, 10:31 PM
epriestley added a comment.Jul 17 2014, 10:38 PM

This doesn't break anything for English users but I'm waiting on confirmation from a non-English user that it solves something. It's way cleaner overall regardless, but it would be nice to fix this issue too. :P

btrahan mentioned this in T5554: arc fails with svn/git/hg non english locales.Oct 17 2014, 4:57 PM
kugel- added a subscriber: kugel-.Mar 7 2016, 1:55 PM

@epriestley this change works for us in de_DE locales. It would be nice if this was merged.

Revision Contents
Changeset List

Diff 23844

View Options

src/repository/api/ArcanistGitAPI.php

Loading...
View Options

src/repository/api/ArcanistMercurialAPI.php

Loading...
View Options

src/repository/api/ArcanistRepositoryAPI.php

Loading...
View Options

src/repository/api/ArcanistSubversionAPI.php

Loading...
View Options

src/workflow/ArcanistCommitWorkflow.php

Loading...
Phabricator · Built by Phacility