Prevents infinite recursion when trying to save custom fields on projects.
- Group Reviewers
- Maniphest Tasks
- T5606: PhabricatorProjectCustomFields that use storage result in infinite recursion
- Restricted Diffusion Commit
rP17badfacac31: Fix PhabricatorProjectCustomFields to use storage correctly.
- Required Signatures
L28 Phacility Individual Contributor License Agreement
Add a custom field (that is a class, not one configured in the UI) to a project, and try to save it.
Differential impelments these on a subclass (DifferentialStoredCustomField), as does People (PhabricatorUserConfiguredCustomField). However, I think this approach is generally cleaner. The implementation on PhabricatorProjectStandardCustomField is redundant now and could be removed. The implementations in applications other than Maniphest could be lifted into the application's custom field base class.