Differential D9902

Mostly modernize the policy control typeahead
ClosedPublic
Actions

Authored by epriestley on Jul 11 2014, 5:44 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4420: Modernize typeahead datasources

Commits

Restricted Diffusion Commit
rP4135ba48b0b8: Mostly modernize the policy control typeahead

Summary

Ref T4420. This doesn't share all the code it really should, and renders a little odd. Make it more standard.

(Icons aren't handled totally correctly but there's no usability impact and all that code should just get cleaned up.)

Test Plan

Used custom policy typeahead, had a more standard experience.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23769.Jul 11 2014, 5:44 PM

epriestley retitled this revision from to Mostly modernize the policy control typeahead.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4420: Modernize typeahead datasources.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 11 2014, 5:44 PM

Harbormaster completed remote builds in B1652: Diff 23769.Jul 11 2014, 5:46 PM

btrahan accepted this revision.Jul 17 2014, 10:32 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jul 17 2014, 10:32 PM

Closed by commit rP4135ba48b0b8 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

23 lines

webroot/

rsrc/

js/

application/

policy/

behavior-policy-rule-editor.js

18 lines

Diff 23948

View Options

resources/celerity/map.php