Page MenuHomePhabricator

Remove partial objects from Lisk
ClosedPublic

Authored by epriestley on Jul 11 2014, 1:20 PM.
Tags
None
Referenced Files
F14339559: D9895.id23755.diff
Wed, Dec 18, 6:49 PM
Unknown Object (File)
Fri, Dec 13, 1:24 AM
Unknown Object (File)
Mon, Dec 9, 1:11 PM
Unknown Object (File)
Sat, Dec 7, 12:39 AM
Unknown Object (File)
Fri, Dec 6, 3:39 PM
Unknown Object (File)
Tue, Dec 3, 10:38 AM
Unknown Object (File)
Tue, Dec 3, 10:38 AM
Unknown Object (File)
Tue, Dec 3, 10:38 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
T4420: Modernize typeahead datasources
Commits
Restricted Diffusion Commit
rPc52b3c28e166: Remove partial objects from Lisk
Summary

Ref T4420. This was a performance hack introduced long ago to make typeaheads for users a little cheaper. The idea was that you could load some of an object's columns and skip other ones.

We now always load users on demand, so the cost of loading the whole objects is very small. No other use cases ever arose for this, and it seems unlikely that they will in the future. Remove it all.

Test Plan
  • Grepped for CONFIG_PARTIAL_OBJECTS.
  • Grepped for dirtyFields.
  • Grepped for missingFields.
  • Grepped for resetDirtyFields.
  • Grepped for loadColumns.
  • Grepped for loadColumnsWhere.
  • Grepped for loadRawDataWhere.
  • Loaded and saved some lisk objects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Remove partial objects from Lisk.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 17 2014, 10:35 PM
epriestley updated this revision to Diff 23944.

Closed by commit rPc52b3c28e166 (authored by @epriestley).