Paths

Table of Contentst

Parameterize `@{upstream}` in arc to fix Windows
ClosedPublic
Actions

Authored by epriestley on Jul 9 2014, 10:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Feb 13, 8:02 PM

	Unknown Object (File)
	Thu, Jan 30, 3:21 PM

	Unknown Object (File)
	Tue, Jan 28, 9:45 AM

	Unknown Object (File)
	Mon, Jan 27, 11:13 AM

	Unknown Object (File)
	Sat, Jan 25, 7:25 AM

	Unknown Object (File)
	Fri, Jan 24, 8:08 PM

	Unknown Object (File)
	Fri, Jan 24, 5:55 PM

	Unknown Object (File)
	Jan 17 2025, 5:04 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Commits

rARC0be983a7a334: Parameterize `@{upstream}` in arc to fix Windows

Summary

We manually quote this in a couple of places. That works fine on Lunix, but does not work on Windows. Instead, explicitly parameterize the command so the correct quoting rules are applied for the OS.

Test Plan

See IRC; windows user had issues fixed by this. arc:upstream still works locally.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23674.Jul 9 2014, 10:05 PM

epriestley retitled this revision from to Parameterize `@{upstream}` in arc to fix Windows.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 9 2014, 10:05 PM

Harbormaster completed remote builds in B1597: Diff 23674.Jul 9 2014, 10:06 PM

chad accepted this revision.Jul 9 2014, 11:05 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 9 2014, 11:05 PM

Closed by commit rARC0be983a7a334 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistGitAPI.php

6 lines

Diff 23702

View Options

src/repository/api/ArcanistGitAPI.php

Parameterize `@{upstream}` in arc to fix WindowsClosedPublicActions