Page MenuHomePhabricator

Make document signatures visible to only document owners and signers
ClosedPublic

Authored by epriestley on Jun 28 2014, 5:01 PM.
Tags
None
Referenced Files
F18380692: D9764.diff
Thu, Aug 28, 6:09 PM
F18098083: D9764.id23454.diff
Fri, Aug 8, 6:26 PM
F17934598: D9764.diff
Wed, Jul 30, 10:41 PM
Unknown Object (File)
Jun 28 2025, 12:48 PM
Unknown Object (File)
Jun 28 2025, 12:48 PM
Unknown Object (File)
Jun 18 2025, 1:22 AM
Unknown Object (File)
Apr 24 2025, 9:22 PM
Unknown Object (File)
Apr 23 2025, 8:22 PM
Subscribers

Details

Reviewers
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP45d61b711060: Make document signatures visible to only document owners and signers
Summary

Ref T3116. Currently signatures are visible to anyone, but they should be more private than that. Instead, you can see a signature if:

  • It's a signature on a document you can edit; or
  • it's your signature.

I'm going to lock down the signatures page a bit in general, but this makes sure that the root policy is correct.

Test Plan
  • Signed a document.
  • Viewed signatures of a document.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Make document signatures visible to only document owners and signers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: Restricted Maniphest Task.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 28 2014, 5:05 PM
epriestley updated this revision to Diff 23454.

Closed by commit rP45d61b711060 (authored by @epriestley).