Paths

Table of Contentst

Differential D9756

Add classes to Remarkup lists and headers
ClosedPublic
Actions

Authored by epriestley on Jun 27 2014, 3:53 PM.

Details

Reviewers

chad

Maniphest Tasks

Restricted Maniphest Task
T5497: CSS rules are bleeding into widgets in `{Wxxx}` rule

Commits

rPHUaae30d7d2a8e: Add classes to Remarkup lists and headers

Summary

Ref T5497. We have some Remarkup CSS rules like .remarkup ul, which are bleeding into ObjectLists inside {Wxxx} and similar.

Add explicit classes to headers and lists so we can scope the Remarkup rules more tightly.

Test Plan

This stuff is covered by a million billion unit tests.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23423.Jun 27 2014, 3:53 PM

epriestley retitled this revision from to Add classes to Remarkup lists and headers.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T5497: CSS rules are bleeding into widgets in `{Wxxx}` rule.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 27 2014, 3:53 PM

Harbormaster completed remote builds in B1429: Diff 23423.Jun 27 2014, 3:54 PM

There are some classes in phui-fontkit as well that should be scoped to Remarkup

I see tt and a, let me fix those.

i added ul, ol in the LegalPad diff

Add a class to <tt>.
Add a class to <a>.

Harbormaster completed remote builds in B1430: Diff 23425.Jun 27 2014, 4:12 PM

Oh are you not updating the CSS this pass?

Yeah, this stuff lives in libphutil. Next diff will hit the CSS and maybe some of the Phabricator rules.

chad accepted this revision.Jun 27 2014, 4:14 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 27 2014, 4:14 PM

Closed by commit rPHUaae30d7d2a8e (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

__tests__/

remarkup/

12 lines

24 lines

2 lines

2 lines

12 lines

6 lines

6 lines

10 lines

link-with-punctuation.txt

6 lines

link-with-tilde.txt

2 lines

link.txt

2 lines

list-alternate-style.txt

8 lines

list-blow-stack.txt

78 lines

list-checkboxes.txt

20 lines

list-first-style-wins.txt

8 lines

list-hash.txt

8 lines

list-mixed-styles.txt

8 lines

8 lines

6 lines

14 lines

12 lines

8 lines

8 lines

list-vs-codeblock.txt

6 lines

list.txt

4 lines

monospaced-in-monospaced.txt

6 lines

monospaced-plural.txt

2 lines

monospaced.txt

2 lines

ordered-list-with-numbers.txt

20 lines

percent-block-multiline.txt

2 lines

reply-nested.txt

16 lines

simple-table-with-link.txt

2 lines

table.txt

4 lines

toc.txt

6 lines

remarkup/

blockrule/

PhutilRemarkupEngineRemarkupHeaderBlockRule.php

4 lines

PhutilRemarkupEngineRemarkupHorizontalRuleBlockRule.php

2 lines

PhutilRemarkupEngineRemarkupListBlockRule.php

18 lines

markuprule/

PhutilRemarkupRuleDocumentLink.php

1 line

PhutilRemarkupRuleHyperlink.php

1 line

PhutilRemarkupRuleMonospace.php

7 lines

Diff 23426

View Options

src/markup/engine/tests/remarkup/headers.txt

View Options

src/markup/engine/tests/remarkup/horizonal-rule.txt

View Options

src/markup/engine/tests/remarkup/link-alternate.txt

View Options

src/markup/engine/tests/remarkup/link-brackets.txt

View Options

src/markup/engine/tests/remarkup/link-edge-cases.txt

View Options

src/markup/engine/tests/remarkup/link-mailto.txt

View Options

src/markup/engine/tests/remarkup/link-mixed.txt

View Options

src/markup/engine/tests/remarkup/link-square.txt

View Options

src/markup/engine/tests/remarkup/link-with-punctuation.txt

View Options

src/markup/engine/tests/remarkup/link-with-tilde.txt

View Options

src/markup/engine/tests/remarkup/link.txt

View Options

src/markup/engine/tests/remarkup/list-alternate-style.txt

View Options

src/markup/engine/tests/remarkup/list-blow-stack.txt

View Options

src/markup/engine/tests/remarkup/list-checkboxes.txt

View Options

src/markup/engine/tests/remarkup/list-first-style-wins.txt

View Options

src/markup/engine/tests/remarkup/list-hash.txt

View Options

src/markup/engine/tests/remarkup/list-mixed-styles.txt

View Options

src/markup/engine/tests/remarkup/list-multi.txt

View Options

src/markup/engine/tests/remarkup/list-multiline.txt

View Options

src/markup/engine/tests/remarkup/list-nest.txt

View Options

src/markup/engine/tests/remarkup/list-staircase.txt

View Options

src/markup/engine/tests/remarkup/list-star.txt

View Options

src/markup/engine/tests/remarkup/list-then-a-list.txt

View Options

src/markup/engine/tests/remarkup/list-vs-codeblock.txt

View Options

src/markup/engine/tests/remarkup/list.txt

View Options

src/markup/engine/tests/remarkup/monospaced-in-monospaced.txt

View Options

src/markup/engine/tests/remarkup/monospaced-plural.txt

View Options

src/markup/engine/tests/remarkup/monospaced.txt

View Options

src/markup/engine/tests/remarkup/ordered-list-with-numbers.txt

View Options

src/markup/engine/tests/remarkup/percent-block-multiline.txt

View Options

src/markup/engine/tests/remarkup/reply-nested.txt

View Options

src/markup/engine/tests/remarkup/simple-table-with-link.txt

View Options

src/markup/engine/tests/remarkup/table.txt

View Options

src/markup/engine/tests/remarkup/toc.txt

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupHeaderBlockRule.php

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupHorizontalRuleBlockRule.php

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupListBlockRule.php

View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleDocumentLink.php

View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleHyperlink.php

View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleMonospace.php

Add classes to Remarkup lists and headersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23426

src/markup/engine/__tests__/remarkup/headers.txt

src/markup/engine/__tests__/remarkup/horizonal-rule.txt

src/markup/engine/__tests__/remarkup/link-alternate.txt

src/markup/engine/__tests__/remarkup/link-brackets.txt

src/markup/engine/__tests__/remarkup/link-edge-cases.txt

src/markup/engine/__tests__/remarkup/link-mailto.txt

src/markup/engine/__tests__/remarkup/link-mixed.txt

src/markup/engine/__tests__/remarkup/link-square.txt

src/markup/engine/__tests__/remarkup/link-with-punctuation.txt

src/markup/engine/__tests__/remarkup/link-with-tilde.txt

src/markup/engine/__tests__/remarkup/link.txt

src/markup/engine/__tests__/remarkup/list-alternate-style.txt

src/markup/engine/__tests__/remarkup/list-blow-stack.txt

src/markup/engine/__tests__/remarkup/list-checkboxes.txt

src/markup/engine/__tests__/remarkup/list-first-style-wins.txt

src/markup/engine/__tests__/remarkup/list-hash.txt

src/markup/engine/__tests__/remarkup/list-mixed-styles.txt

src/markup/engine/__tests__/remarkup/list-multi.txt

src/markup/engine/__tests__/remarkup/list-multiline.txt

src/markup/engine/__tests__/remarkup/list-nest.txt

src/markup/engine/__tests__/remarkup/list-staircase.txt

src/markup/engine/__tests__/remarkup/list-star.txt

src/markup/engine/__tests__/remarkup/list-then-a-list.txt

src/markup/engine/__tests__/remarkup/list-vs-codeblock.txt

src/markup/engine/__tests__/remarkup/list.txt

src/markup/engine/__tests__/remarkup/monospaced-in-monospaced.txt

src/markup/engine/__tests__/remarkup/monospaced-plural.txt

src/markup/engine/__tests__/remarkup/monospaced.txt

src/markup/engine/__tests__/remarkup/ordered-list-with-numbers.txt

src/markup/engine/__tests__/remarkup/percent-block-multiline.txt

src/markup/engine/__tests__/remarkup/reply-nested.txt

src/markup/engine/__tests__/remarkup/simple-table-with-link.txt

src/markup/engine/__tests__/remarkup/table.txt

src/markup/engine/__tests__/remarkup/toc.txt

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupHeaderBlockRule.php

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupHorizontalRuleBlockRule.php

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupListBlockRule.php

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleDocumentLink.php

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleHyperlink.php

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleMonospace.php

Add classes to Remarkup lists and headers
ClosedPublic
Actions

Revision Contents
Changeset List

src/markup/engine/tests/remarkup/headers.txt

src/markup/engine/tests/remarkup/horizonal-rule.txt

src/markup/engine/tests/remarkup/link-alternate.txt

src/markup/engine/tests/remarkup/link-brackets.txt

src/markup/engine/tests/remarkup/link-edge-cases.txt

src/markup/engine/tests/remarkup/link-mailto.txt

src/markup/engine/tests/remarkup/link-mixed.txt

src/markup/engine/tests/remarkup/link-square.txt

src/markup/engine/tests/remarkup/link-with-punctuation.txt

src/markup/engine/tests/remarkup/link-with-tilde.txt

src/markup/engine/tests/remarkup/link.txt

src/markup/engine/tests/remarkup/list-alternate-style.txt

src/markup/engine/tests/remarkup/list-blow-stack.txt

src/markup/engine/tests/remarkup/list-checkboxes.txt

src/markup/engine/tests/remarkup/list-first-style-wins.txt

src/markup/engine/tests/remarkup/list-hash.txt

src/markup/engine/tests/remarkup/list-mixed-styles.txt

src/markup/engine/tests/remarkup/list-multi.txt

src/markup/engine/tests/remarkup/list-multiline.txt

src/markup/engine/tests/remarkup/list-nest.txt

src/markup/engine/tests/remarkup/list-staircase.txt

src/markup/engine/tests/remarkup/list-star.txt

src/markup/engine/tests/remarkup/list-then-a-list.txt

src/markup/engine/tests/remarkup/list-vs-codeblock.txt

src/markup/engine/tests/remarkup/list.txt

src/markup/engine/tests/remarkup/monospaced-in-monospaced.txt

src/markup/engine/tests/remarkup/monospaced-plural.txt

src/markup/engine/tests/remarkup/monospaced.txt

src/markup/engine/tests/remarkup/ordered-list-with-numbers.txt

src/markup/engine/tests/remarkup/percent-block-multiline.txt

src/markup/engine/tests/remarkup/reply-nested.txt

src/markup/engine/tests/remarkup/simple-table-with-link.txt

src/markup/engine/tests/remarkup/table.txt

src/markup/engine/tests/remarkup/toc.txt