Page MenuHomePhabricator
Differential D9746

Slimmer Shade Tags
ClosedPublic
Actions

Authored by chad on Jun 26 2014, 9:13 PM.
Tags
None
Referenced Files
F14038447: D9746.id23406.diff
Sun, Nov 10, 11:41 PM
F14035623: D9746.diff
Sun, Nov 10, 6:48 AM
F14017034: D9746.id23406.diff
Mon, Nov 4, 1:50 PM
F14008925: D9746.id23406.diff
Wed, Oct 30, 8:02 AM
F13987309: D9746.id23406.diff
Mon, Oct 21, 8:40 AM
F13967364: D9746.diff
Oct 16 2024, 1:07 PM
F13966401: D9746.id23406.diff
Oct 16 2024, 7:55 AM
Unknown Object (File)
Sep 25 2024, 4:06 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPe096a227db1d: Slimmer Shade Tags
Summary

Shaves a pixel for use in ObjectLists.

Test Plan

UIExamples.

undefined (432×380 px, 29 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 23405.Jun 26 2014, 9:13 PM
chad retitled this revision from to Slimmer Shade Tags.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 26 2014, 9:13 PM
chad edited the test plan for this revision. (Show Details)Jun 26 2014, 9:14 PM
Harbormaster completed remote builds in B1417: Diff 23405.Jun 26 2014, 9:14 PM
epriestley edited edge metadata.Jun 26 2014, 9:17 PM

wow such savings!

epriestley accepted this revision.Jun 26 2014, 9:17 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 26 2014, 9:17 PM
chad closed this revision.Jun 26 2014, 9:19 PM
chad updated this revision to Diff 23406.

Closed by commit rPe096a227db1d (authored by @chad).

chad added a comment.Jun 26 2014, 9:22 PM

erm, wait did I just make this for nothing, looks like the obj list shades are already smaller?

epriestley added inline comments.Jun 26 2014, 9:26 PM
webroot/rsrc/css/phui/phui-tag-view.css
319–346

I have hard-coded rules down here which were my coarse pass at this, but the explicit slimming is better and your numbers are a little different (and presumably superior).

epriestley added a comment.Jun 26 2014, 9:27 PM

I'll shoot you a diff to swap over to this and toss out my rules, but I'm going to try Shovel Knight first.

shovel shovel shovel

chad added a comment.Jun 26 2014, 9:28 PM

Yes, but it's the same size as where I wanted to replace (ObjList) so it's not actually slimmer there.

Here is another pass (shaves another 2px:

undefined (228×826 px, 27 KB)

chad added a comment.Jun 26 2014, 9:28 PM

Oh I paid for that on Kickstarter, guess I should download.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
uiexample/
examples/
8 lines
view/
phui/
10 lines
webroot/
rsrc/
css/
phui/
11 lines

Diff 23406

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/uiexample/examples/PHUITagExample.php

Loading...
View Options

src/view/phui/PHUITagView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-tag-view.css

Loading...
Phabricator · Built by Phacility