Page MenuHomePhabricator
Differential D9743

Move project icon editing into "Edit Details"
ClosedPublic
Actions

Authored by epriestley on Jun 26 2014, 3:48 PM.
Tags
None
Referenced Files
F14058024: D9743.diff
Sun, Nov 17, 8:47 AM
F14048960: D9743.diff
Thu, Nov 14, 10:29 AM
F14034385: D9743.diff
Sat, Nov 9, 11:55 PM
F14005535: D9743.id23397.diff
Sun, Oct 27, 3:06 PM
F14002233: D9743.diff
Fri, Oct 25, 4:35 PM
F14002226: D9743.id.diff
Fri, Oct 25, 4:30 PM
F14002224: D9743.id23397.diff
Fri, Oct 25, 4:29 PM
F14002219: D9743.id23401.diff
Fri, Oct 25, 4:27 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T5482: Align Colors/Icon Picker in Projects
Commits
Restricted Diffusion Commit
rP195def15b0ca: Move project icon editing into "Edit Details"
Summary

Ref T5482. Instead of editing icons and details seaparetly, use a bunch of Javascript to pop a dialog instead.

Test Plan

Screen_Shot_2014-06-26_at_8.47.01_AM.png (1×1 px, 149 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23397.Jun 26 2014, 3:48 PM
epriestley retitled this revision from to Move project icon editing into "Edit Details".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5482: Align Colors/Icon Picker in Projects.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 26 2014, 3:48 PM
Harbormaster completed remote builds in B1414: Diff 23397.Jun 26 2014, 3:49 PM
chad accepted this revision.Jun 26 2014, 3:56 PM
chad edited edge metadata.
chad added inline comments.
webroot/rsrc/js/core/behavior-choose-control.js
2–32

sorry

This revision is now accepted and ready to land.Jun 26 2014, 3:56 PM
epriestley closed this revision.Jun 26 2014, 4:41 PM
epriestley updated this revision to Diff 23401.

Closed by commit rP195def15b0ca (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
35 lines
src/
2 lines
applications/
project/
controller/
18 lines
30 lines
8 lines
icon/
14 lines
view/
form/
control/
96 lines
webroot/
rsrc/
css/
phui/
10 lines
js/
core/
31 lines
5 lines

Diff 23401

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditDetailsController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditIconController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditMainController.php

Loading...
View Options

src/applications/project/icon/PhabricatorProjectIcon.php

Loading...
View Options

src/view/form/control/AphrontFormChooseButtonControl.php

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
View Options

webroot/rsrc/js/core/behavior-choose-control.js

Loading...
View Options

webroot/rsrc/js/core/behavior-tooltip.js

Loading...
Phabricator · Built by Phacility