Differential D9742

Move project color editing to "Edit Details" from "Edit Icon"
ClosedPublic
Actions

Authored by epriestley on Jun 26 2014, 3:13 PM.

Details

Reviewers

chad

Maniphest Tasks

T5482: Align Colors/Icon Picker in Projects

Commits

Restricted Diffusion Commit
rPc6a58b85c524: Move project color editing to "Edit Details" from "Edit Icon"

Summary

Fixes T5482. This isn't perfect but seems less confusing/ugly on the balance.

Test Plan

Edited color under "Edit Details".
Edited icon under "Edit Icon".
No weird submit button state issue.
No weird alignmnet issue.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23396.Jun 26 2014, 3:13 PM

epriestley retitled this revision from to Move project color editing to "Edit Details" from "Edit Icon".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T5482: Align Colors/Icon Picker in Projects.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 26 2014, 3:13 PM

Harbormaster completed remote builds in B1413: Diff 23396.Jun 26 2014, 3:15 PM

chad accepted this revision.Jun 26 2014, 3:40 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 26 2014, 3:40 PM

Closed by commit rPc6a58b85c524 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectEditDetailsController.php

19 lines

PhabricatorProjectEditIconController.php

27 lines

Diff 23399

View Options

src/applications/project/controller/PhabricatorProjectEditDetailsController.php