Page MenuHomePhabricator

Use standard tag elements instead of "maniphest project tag" to show tags in list views
ClosedPublic

Authored by epriestley on Jun 26 2014, 2:52 PM.
Tags
None
Referenced Files
F14062029: D9741.id23395.diff
Mon, Nov 18, 9:55 AM
F14062028: D9741.id23394.diff
Mon, Nov 18, 9:55 AM
F14062027: D9741.id23398.diff
Mon, Nov 18, 9:55 AM
F14059134: D9741.diff
Sun, Nov 17, 5:38 PM
F14033589: D9741.diff
Sat, Nov 9, 6:26 PM
F14002201: D9741.diff
Fri, Oct 25, 4:17 PM
F14002187: D9741.id.diff
Fri, Oct 25, 4:07 PM
F14002185: D9741.id23394.diff
Fri, Oct 25, 4:06 PM
Subscribers

Details

Summary

Standardizes tag rendering in Maniphest and Maniphest/Diffusion list views.

(This might need some size/spacing tweaks, I tried to make it look reasonable.)

Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Use standard tag elements instead of "maniphest project tag" to show tags in list views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

My test data is pretty junk, but normal-ish view:

Screen_Shot_2014-06-26_at_7.47.52_AM.png (1×1 px, 181 KB)

With a column (I probably want to make this "Project > Column" in the tag eventually?):

Screen_Shot_2014-06-26_at_7.55.38_AM.png (350×1 px, 64 KB)

With too many projects:

Screen_Shot_2014-06-26_at_7.57.12_AM.png (1×1 px, 190 KB)

In Diffusion / restricted style:

Screen_Shot_2014-06-26_at_7.57.43_AM.png (120×1 px, 19 KB)

  • Fix a minor Celerity issue.

Looks OK. Also thought about the Typeahead, don't think it's worth even testing. Mostly because Typeaheads are interfaces for quickly selecting objects you already know, I don't think the color adds anything new.

chad edited edge metadata.
This revision is now accepted and ready to land.Jun 26 2014, 3:15 PM
epriestley updated this revision to Diff 23398.

Closed by commit rP41adc1b4c3db (authored by @epriestley).