Page MenuHomePhabricator

Projects for DifferentialRevision
ClosedPublic

Authored by lpriestley on Jun 23 2014, 3:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 4:10 AM
Unknown Object (File)
Sat, Dec 14, 2:04 PM
Unknown Object (File)
Thu, Dec 12, 11:09 AM
Unknown Object (File)
Thu, Dec 12, 2:13 AM
Unknown Object (File)
Sun, Dec 8, 4:34 AM
Unknown Object (File)
Sat, Dec 7, 11:32 AM
Unknown Object (File)
Thu, Dec 5, 7:02 AM
Unknown Object (File)
Mon, Dec 2, 12:43 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP248b4dfa9d61: Projects for DifferentialRevision
Summary

T2628, Adding project tags to revisions

Test Plan

Edit revision, verify projects can be tagged. Add project hashtag to comments or commit templates, verify revision is tagged with project

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

lpriestley retitled this revision from to Projects for DifferentialRevision.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.

Two tiny issues.

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
26–28

Let's put the field here, underneath the Repository field. It's useful, but not more important than author/reviewers/etc.

src/applications/differential/customfield/DifferentialProjectsField.php
33–42

For consistency, un-indent this function body one level (as you would if the parameter wasn't wrapped).

This revision now requires changes to proceed.Jun 23 2014, 4:13 PM
lpriestley edited edge metadata.

Cosmetic code changes

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2014, 4:49 PM
epriestley updated this revision to Diff 23241.

Closed by commit rP248b4dfa9d61 (authored by @lpriestley, committed by @epriestley).