Page MenuHomePhabricator
Differential D9574

Make the Pholio download button actually download
ClosedPublic
Actions

Authored by epriestley on Jun 16 2014, 3:56 PM.
Tags
None
Referenced Files
F14045210: D9574.id22943.diff
Wed, Nov 13, 2:13 AM
F14036266: D9574.id22941.diff
Sun, Nov 10, 9:25 AM
F14035977: D9574.diff
Sun, Nov 10, 8:09 AM
F13999176: D9574.id22943.diff
Thu, Oct 24, 1:13 PM
F13997999: D9574.id.diff
Thu, Oct 24, 7:10 AM
F13984649: D9574.id22941.diff
Sun, Oct 20, 2:54 PM
Unknown Object (File)
Oct 6 2024, 1:20 PM
Unknown Object (File)
Oct 3 2024, 7:25 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP0efa1ca6430a: Make the Pholio download button actually download
Summary
  • When the button is clicked, actually download the file or image.
  • Add aural hints for the icon-only buttons.
  • Use a "photo" icon for "view raw image", so the "arrows pointing outward" icon can be used for "fullscreen" some day.
Test Plan

Clicked link, got a download.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22941.Jun 16 2014, 3:56 PM
epriestley retitled this revision from to Make the Pholio download button actually download.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 16 2014, 3:56 PM
Harbormaster completed remote builds in B1142: Diff 22941.Jun 16 2014, 3:57 PM
chad accepted this revision.Jun 16 2014, 4:00 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2014, 4:00 PM
epriestley closed this revision.Jun 16 2014, 4:15 PM
epriestley updated this revision to Diff 22943.

Closed by commit rP0efa1ca6430a (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
pholio/
view/
16 lines
webroot/
rsrc/
css/
application/
pholio/
22 lines
js/
application/
pholio/
23 lines

Diff 22943

View Options

src/applications/pholio/view/PholioMockImagesView.php

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio.css

Loading...
View Options

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

Loading...
Phabricator · Built by Phacility