Support "Projects" field for pholio mocks in Herald
ClosedPublic
Actions

Authored by epriestley on Jun 15 2014, 5:59 PM.

Tags

None

Referenced Files

	F18458716: D9552.id22906.diff
	Mon, Sep 1, 3:13 PM

	F18458499: D9552.id.diff
	Mon, Sep 1, 2:40 PM

	F18401906: D9552.id.diff
	Fri, Aug 29, 7:42 PM

	F18371541: D9552.diff
	Thu, Aug 28, 5:19 AM

	F18087135: D9552.id22895.diff
	Wed, Aug 6, 2:33 AM

	Unknown Object (File)
	Jul 2 2025, 8:12 PM

	Unknown Object (File)
	Jun 9 2025, 2:25 AM

	Unknown Object (File)
	May 20 2025, 5:31 PM

View All Files

Subscribers

epriestley

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP397d67ff3d08: Support "Projects" field for pholio mocks in Herald

Summary

Mocks can have projects now; allow Herald rules to be written against them.

Test Plan

Wrote a Herald mock rule about projects.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22895.Jun 15 2014, 5:59 PM

epriestley retitled this revision from to Support "Projects" field for pholio mocks in Herald.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 15 2014, 5:59 PM

Harbormaster completed remote builds in B1116: Diff 22895.Jun 15 2014, 6:00 PM

chad accepted this revision.Jun 15 2014, 6:26 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 15 2014, 6:26 PM

Closed by commit rP397d67ff3d08 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

herald/

adapter/

HeraldPholioMockAdapter.php

13 lines

Diff 22906

View Options

src/__phutil_library_map__.php