Support "Projects" field for pholio mocks in Herald
ClosedPublic
Actions

Authored by epriestley on Jun 15 2014, 5:59 PM.

Tags

None

Referenced Files

	F15414777: D9552.id.diff
	Thu, Mar 20, 2:31 AM

	F15382404: D9552.diff
	Fri, Mar 14, 12:10 PM

	F15375010: D9552.diff
	Wed, Mar 12, 9:07 PM

	Unknown Object (File)
	Wed, Feb 26, 4:43 AM

	Unknown Object (File)
	Tue, Feb 25, 4:57 PM

	Unknown Object (File)
	Feb 9 2025, 1:35 PM

	Unknown Object (File)
	Feb 9 2025, 1:35 PM

	Unknown Object (File)
	Feb 9 2025, 1:35 PM

View All Files

Subscribers

epriestley

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP397d67ff3d08: Support "Projects" field for pholio mocks in Herald

Summary

Mocks can have projects now; allow Herald rules to be written against them.

Test Plan

Wrote a Herald mock rule about projects.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22895.Jun 15 2014, 5:59 PM

epriestley retitled this revision from to Support "Projects" field for pholio mocks in Herald.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 15 2014, 5:59 PM

Harbormaster completed remote builds in B1116: Diff 22895.Jun 15 2014, 6:00 PM

chad accepted this revision.Jun 15 2014, 6:26 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 15 2014, 6:26 PM

Closed by commit rP397d67ff3d08 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

herald/

adapter/

HeraldPholioMockAdapter.php

13 lines

Diff 22906

View Options

src/__phutil_library_map__.php