Allow the Pholio stage to scroll vertically
ClosedPublic
Actions

Authored by epriestley on Jun 15 2014, 1:54 AM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rP8b1b52ea70cf: Allow the Pholio stage to scroll vertically

Summary

Currently, we limit the image size to make sure that the stage has a constant height and the entire image always fits on screen.

In practice, these don't actually seem like desirable qualities. Instead, focus on giving as many pixels as possible to the image.

Test Plan

See screenshots.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22863.Jun 15 2014, 1:54 AM

epriestley retitled this revision from to Allow the Pholio stage to scroll vertically.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 15 2014, 1:54 AM

Before, if the image was too tall to fit on screen without scrolling, we would resize it vertically to fit it on screen:

Screen_Shot_2014-06-14_at_6.51.33_PM.png (614×1 px, 249 KB)

Instead, only resize the image if it would need to scroll horizontally:

Screen_Shot_2014-06-14_at_6.51.43_PM.png (614×1 px, 303 KB)

Harbormaster completed remote builds in B1098: Diff 22863.Jun 15 2014, 1:56 AM

We might still want a 'Full Size' JS button when it's scale, but it could be this resolves 95% of complaints.

chad accepted this revision.Jun 15 2014, 2:04 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 15 2014, 2:04 AM

Closed by commit rP8b1b52ea70cf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

44 lines

webroot/

rsrc/

js/

application/

pholio/

behavior-pholio-mock-view.js

27 lines

Diff 22866

View Options

resources/celerity/map.php