Page MenuHomePhabricator
Differential D9531

Use PHUIPinboard UI for embedding Pholio Mocks
ClosedPublic
Actions

Authored by chad on Jun 14 2014, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 11, 3:23 AM
Unknown Object (File)
Sun, Jan 5, 12:19 PM
Unknown Object (File)
Sat, Jan 4, 7:49 PM
Unknown Object (File)
Thu, Jan 2, 2:55 AM
Unknown Object (File)
Dec 14 2024, 4:15 PM
Unknown Object (File)
Dec 13 2024, 3:44 AM
Unknown Object (File)
Dec 9 2024, 9:18 AM
Unknown Object (File)
Dec 6 2024, 1:28 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPf801c8fed9e0: Use PHUIPinboard UI for embedding Pholio Mocks
Summary

Changes the old dark embed to match the PinboardView. Retains ability to target individual files. Removes "carousel" of files (not super useful?)

Test Plan

Tested embedding Mocks, with and without targeting specific files. Tested Pholio Pinboard, Macro Pinboard.

Screen_Shot_2014-06-14_at_10.20.49_AM.png (356×935 px, 128 KB)

Screen_Shot_2014-06-14_at_11.59.02_AM.png (713×341 px, 107 KB)

Screen_Shot_2014-06-14_at_10.20.28_AM.png (1×352 px, 137 KB)

Screen_Shot_2014-06-14_at_10.20.40_AM.png (685×615 px, 150 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 22847.Jun 14 2014, 7:02 PM
chad retitled this revision from to Use PHUIPinboard UI for embedding Pholio Mocks.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 14 2014, 7:02 PM
chad edited the test plan for this revision. (Show Details)Jun 14 2014, 7:03 PM
Harbormaster completed remote builds in B1087: Diff 22847.Jun 14 2014, 7:03 PM
epriestley accepted this revision.Jun 14 2014, 7:09 PM
epriestley edited edge metadata.

If we do want the carousel at some point, maybe it could be a feature of this view (e.g., some hover/click-to-preview kind of thing) so that every UI benefits from it. But I agree that it's not terribly useful.

This revision is now accepted and ready to land.Jun 14 2014, 7:09 PM
chad closed this revision.Jun 14 2014, 7:11 PM
chad updated this revision to Diff 22848.

Closed by commit rPf801c8fed9e0 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
applications/
pholio/
remarkup/
1 line
view/
107 lines
view/
phui/
30 lines
webroot/
rsrc/
css/
application/
pholio/
34 lines
phui/
24 lines

Diff 22848

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/pholio/remarkup/PholioRemarkupRule.php

Loading...
View Options

src/applications/pholio/view/PholioMockEmbedView.php

Loading...
View Options

src/view/phui/PHUIPinboardItemView.php

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio.css

Loading...
View Options

webroot/rsrc/css/phui/phui-pinboard-view.css

Loading...
Phabricator · Built by Phacility