Page MenuHomePhabricator
Differential D9524

Add app icons to search typeahead
ClosedPublic
Actions

Authored by chad on Jun 14 2014, 4:06 AM.
Tags
None
Referenced Files
F13243378: D9524.id22827.diff
Thu, May 23, 3:51 AM
F13238711: D9524.id.diff
Tue, May 21, 8:53 PM
F13234745: D9524.diff
Tue, May 21, 3:43 AM
F13215039: D9524.id22827.diff
Fri, May 17, 2:26 PM
F13215038: D9524.id22833.diff
Fri, May 17, 2:26 PM
F13215037: D9524.id22828.diff
Fri, May 17, 2:26 PM
F13212700: D9524.diff
Fri, May 17, 6:59 AM
F13197257: D9524.diff
Sun, May 12, 11:57 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP4d30841100b4: Add app icons to search typeahead
Summary

Seems likely reasonable.

Test Plan

Search for apps and other stuff, seems good.

Screen_Shot_2014-06-13_at_9.00.51_PM.png (632×732 px, 64 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 22827.Jun 14 2014, 4:06 AM
chad retitled this revision from to Add app icons to search typeahead.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 14 2014, 4:06 AM
chad edited the test plan for this revision. (Show Details)Jun 14 2014, 4:07 AM
Harbormaster completed remote builds in B1073: Diff 22827.Jun 14 2014, 4:07 AM
chad updated this revision to Diff 22828.Jun 14 2014, 4:16 AM
  • pixel
Harbormaster completed remote builds in B1074: Diff 22828.Jun 14 2014, 4:17 AM
chad added inline comments.Jun 14 2014, 4:23 AM
webroot/rsrc/js/core/behavior-search-typeahead.js
29

omg this was so painful

epriestley accepted this revision.Jun 14 2014, 5:43 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 14 2014, 5:43 PM
chad closed this revision.Jun 14 2014, 6:03 PM
chad updated this revision to Diff 22833.

Closed by commit rP4d30841100b4 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
32 lines
src/
applications/
typeahead/
controller/
11 lines
storage/
7 lines
webroot/
rsrc/
css/
application/
base/
10 lines
js/
core/
1 line

Diff 22833

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php

Loading...
View Options

src/applications/typeahead/storage/PhabricatorTypeaheadResult.php

Loading...
View Options

webroot/rsrc/css/application/base/main-menu-view.css

Loading...
View Options

webroot/rsrc/js/core/behavior-search-typeahead.js

Loading...
Phabricator · Built by Phacility