Page MenuHomePhabricator
Differential D9516

Remove double border on tables in object boxes
ClosedPublic
Actions

Authored by chad on Jun 13 2014, 6:16 PM.
Tags
None
Referenced Files
F14712036: D9516.id22811.diff
Fri, Jan 17, 3:29 PM
Unknown Object (File)
Dec 13 2024, 4:03 AM
Unknown Object (File)
Dec 9 2024, 11:25 AM
Unknown Object (File)
Dec 4 2024, 5:32 AM
Unknown Object (File)
Dec 2 2024, 6:58 PM
Unknown Object (File)
Dec 1 2024, 12:08 PM
Unknown Object (File)
Nov 27 2024, 3:38 AM
Unknown Object (File)
Nov 23 2024, 6:47 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP27c2299407f3: Remove double border on tables in object boxes
Summary

The CSS rule tends to miss many tables, make the rule more universal and add borders as needed.

Test Plan

Test a Revision and Diffusion

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 22811.Jun 13 2014, 6:16 PM
chad retitled this revision from to Remove double border on tables in object boxes.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 13 2014, 6:16 PM
Harbormaster completed remote builds in B1063: Diff 22811.Jun 13 2014, 6:18 PM
epriestley accepted this revision.Jun 13 2014, 6:20 PM
epriestley edited edge metadata.

(The ones in Differential are also because there are hidden anchors in the boxes, but we could move those outside of the boxes. This seems cleaner overall, though.)

This revision is now accepted and ready to land.Jun 13 2014, 6:20 PM
chad closed this revision.Jun 13 2014, 6:36 PM
chad updated this revision to Diff 22814.

Closed by commit rP27c2299407f3 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
applications/
diffusion/
controller/
9 lines
webroot/
rsrc/
css/
aphront/
8 lines
application/
diffusion/
4 lines

Diff 22814

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

webroot/rsrc/css/aphront/table-view.css

Loading...
View Options

webroot/rsrc/css/application/diffusion/diffusion-icons.css

Loading...
Phabricator · Built by Phacility