Page MenuHomePhabricator
Differential D9505

Allow users to "Edit a Copy" when trying to edit a panel they don't own
ClosedPublic
Actions

Authored by epriestley on Jun 12 2014, 9:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 10:24 AM
Unknown Object (File)
Thu, Apr 25, 3:28 AM
Unknown Object (File)
Sun, Apr 21, 3:34 PM
Unknown Object (File)
Thu, Apr 11, 5:04 AM
Unknown Object (File)
Mar 15 2024, 9:39 PM
Unknown Object (File)
Feb 27 2024, 3:02 AM
Unknown Object (File)
Feb 27 2024, 3:02 AM
Unknown Object (File)
Feb 26 2024, 12:07 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T5259: Action icons aren't clickable in Firefox on grippable object item views
T5167: Dashboards should offer "Edit a Copy" when trying to edit a panel you can't edit
Commits
Restricted Diffusion Commit
rP408d71cdd33b: Allow users to "Edit a Copy" when trying to edit a panel they don't own
Summary

Fixes T5167. When clicking "Edit" on a dashboard panel you don't own, the UI now allows you to make a copy instead.

As a bonus, fixes T5259.

Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22772.Jun 12 2014, 9:13 PM
epriestley retitled this revision from to Allow users to "Edit a Copy" when trying to edit a panel they don't own.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T5167: Dashboards should offer "Edit a Copy" when trying to edit a panel you can't edit, T5259: Action icons aren't clickable in Firefox on grippable object item views.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 12 2014, 9:13 PM
epriestley added a comment.Jun 12 2014, 9:14 PM

New prompt:

Screen_Shot_2014-06-12_at_2.11.31_PM.png (1×1 px, 279 KB)

I think I missed the screenshot, but then you get a second dialog letting you edit the copy normally.

Finally, the copy replaces the old one:

Screen_Shot_2014-06-12_at_2.11.46_PM.png (1×1 px, 275 KB)

Harbormaster completed remote builds in B1039: Diff 22772.Jun 12 2014, 9:14 PM
chad accepted this revision.Jun 12 2014, 9:40 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 12 2014, 9:40 PM
epriestley closed this revision.Jun 12 2014, 10:15 PM
epriestley updated this revision to Diff 22774.

Closed by commit rP408d71cdd33b (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
28 lines
src/
applications/
dashboard/
controller/
4 lines
117 lines
layoutconfig/
12 lines
storage/
8 lines
webroot/
rsrc/
js/
core/
11 lines

Diff 22774

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardManageController.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php

Loading...
View Options

src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

Loading...
View Options

webroot/rsrc/js/core/DraggableList.js

Loading...
Phabricator · Built by Phacility