Differential D9502

Style quote reply headers
ClosedPublic
Actions

Authored by chad on Jun 12 2014, 4:15 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T4962: Maybe improve styles for nested blockquotes and quoted text

Commits

Restricted Diffusion Commit
rP96a7868fe027: Style quote reply headers

Summary

Adds some minor tweaks to the Quoted Remarkup rules. I tried altering the nested quote as well, but it became a bit of a joke quickly, not sure there is benefit there. Fixes T4962

Test Plan

Quoted lots of times.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad updated this revision to Diff 22761.Jun 12 2014, 4:15 PM

chad retitled this revision from to Style quote reply headers.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T4962: Maybe improve styles for nested blockquotes and quoted text.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 12 2014, 4:15 PM

For posterity:

Harbormaster completed remote builds in B1033: Diff 22761.Jun 12 2014, 4:16 PM

I didn't implement the background color changes, but there's the best it could look at least.

chad edited the test plan for this revision. (Show Details)Jun 12 2014, 4:17 PM

hehehe

I don't totally hate the backgrounds if ever want to ship them -- they're super silly, but deep quoting is pretty goofy too. They could be an on-purpose joke and go grey, slightly-darker, slightly-slightly-darker, slightly-red, slightly-orange, slightly-yellow, slightly-green, ...

This revision is now accepted and ready to land.Jun 12 2014, 5:23 PM

Closed by commit rP96a7868fe027 (authored by @chad).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

core/

remarkup.css

13 lines

Diff 22767

View Options

resources/celerity/map.php