Page MenuHomePhabricator

Possibly ugly fix to get a local binary to work with arc lint
AbandonedPublic

Authored by bluehawk on Jun 11 2014, 6:38 PM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Also check Filesystem::pathExists() in case the binary is local, for example <project root>/vendor/bin/phpcs
It might be worth mentioning that this was tested on windows.

Test Plan

composer require --dev squizlabs/php_codesniffer, then edit composer.json and add

"config": {
    "bin-dir": "bin"
},

Then in .arclint add:

"phpcs": {
    "type": "phpcs",
    "include": "(\\.php$|\\.inc$)",
    "bin": "vendor/bin/phpcs"
}

and run arc lint.

Diff Detail

Repository
rARC Arcanist
Branch
local-arc-lint-bin
Lint
Lint Skipped
Unit
Test Failures
Build Status
Buildable 1008
Build 1008: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
0 mstestCSSLintLinter
0 mstestPEP8Linter
0 mstestPHPCSLint
0 mstestPhutilXHPASTLint
0 mstestRubyLint
View Full Test Results (8 Failed · 2 Passed · 11 Skipped)

Event Timeline

bluehawk retitled this revision from to Possibly ugly fix to get a local binary to work with arc lint.
bluehawk updated this object.
bluehawk edited the test plan for this revision. (Show Details)
bluehawk added a reviewer: epriestley.

I thought I would take a stab at this, but I clearly did something wrong, as all the unit tests blew up on me.

Ignore this one, I think that D9493 is a better solution.