Page MenuHomePhabricator
Differential D9426

Touch up Subscriber List Dialog
ClosedPublic
Actions

Authored by chad on Jun 8 2014, 3:58 AM.
Tags
None
Referenced Files
F13194168: D9426.diff
Sun, May 12, 9:22 PM
F13177232: D9426.diff
Wed, May 8, 7:34 PM
Unknown Object (File)
Mon, Apr 29, 6:13 PM
Unknown Object (File)
Mon, Apr 29, 2:08 PM
Unknown Object (File)
Wed, Apr 24, 9:58 PM
Unknown Object (File)
Fri, Apr 19, 10:20 AM
Unknown Object (File)
Fri, Apr 19, 10:20 AM
Unknown Object (File)
Fri, Apr 19, 9:57 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4891: Fix design of "8 others..." dialog box
Commits
Restricted Diffusion Commit
rP7b97d006a544: Touch up Subscriber List Dialog
Summary

Reduces images in ObjectLists to 40px over 50px, adds ability to show stackable lists in dialogs. Fixes T4891

Test Plan

Tested People, Projects, Subscriber lists.

Screen_Shot_2014-06-07_at_8.51.06_PM.png (854×712 px, 71 KB)

Screen_Shot_2014-06-07_at_8.49.33_PM.png (622×502 px, 37 KB)

Screen_Shot_2014-06-07_at_8.49.23_PM.png (582×760 px, 84 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 22508.Jun 8 2014, 3:58 AM
chad retitled this revision from to Touch up Subscriber List Dialog.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T4891: Fix design of "8 others..." dialog box.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 8 2014, 3:58 AM
Harbormaster completed remote builds in B926: Diff 22508.Jun 8 2014, 3:59 AM
chad edited the test plan for this revision. (Show Details)Jun 8 2014, 3:59 AM
epriestley accepted this revision.Jun 8 2014, 4:39 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2014, 4:39 AM
chad closed this revision.Jun 8 2014, 4:43 AM
chad updated this revision to Diff 22509.

Closed by commit rP7b97d006a544 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
applications/
subscriptions/
controller/
2 lines
view/
7 lines
view/
9 lines
webroot/
rsrc/
css/
aphront/
20 lines
application/
subscriptions/
phui/
11 lines

Diff 22509

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/subscriptions/controller/PhabricatorSubscriptionsListController.php

Loading...
View Options

src/applications/subscriptions/view/SubscriptionListDialogBuilder.php

Loading...
View Options

src/view/AphrontDialogView.php

Loading...
View Options

webroot/rsrc/css/aphront/dialog-view.css

Loading...
View Options

webroot/rsrc/css/application/subscriptions/subscribers-list.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility