Page MenuHomePhabricator

Very rough proof-of-concept of inline-translatable strings
AbandonedPublic

Authored by epriestley on Jun 8 2014, 2:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 10:16 AM
Unknown Object (File)
Thu, Apr 11, 8:21 AM
Unknown Object (File)
Wed, Apr 3, 3:03 PM
Unknown Object (File)
Fri, Mar 29, 4:54 PM
Unknown Object (File)
Sun, Mar 24, 4:41 AM
Unknown Object (File)
Mar 13 2024, 1:04 PM
Unknown Object (File)
Mar 13 2024, 12:58 PM
Unknown Object (File)
Mar 10 2024, 7:12 PM
Subscribers

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5267: Localize Phabricator
Summary

Ref T5267. I'll add some screenshots in a second.

Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Branch
xlate1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 925
Build 925: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Very rough proof-of-concept of inline-translatable strings.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.

This moves language settings to a new settings panel, and adds a checkbox covered with warnings:

Screen_Shot_2014-06-07_at_7.15.32_PM.png (1×1 px, 181 KB)

Enabling it activates translation mode. Translated strings appear with an underline: violet for untranslated, blue for file-translated, and green for user-translated:

Screen_Shot_2014-06-07_at_7.15.41_PM.png (1×1 px, 182 KB)

If you shift-click any translatable text, you can provide a translation:

Screen_Shot_2014-06-07_at_7.16.03_PM.png (1×1 px, 143 KB)

None of this works yet or saves anywhere, but it seems to behave properly, and essentially solve the hardest UI part of doing contextual translation.

chad edited edge metadata.

Textarea seems a bit small given some of our paragraphs, but otherwise cool with me if cool with Bob.

This revision is now accepted and ready to land.Jun 10 2014, 8:50 PM