Page MenuHomePhabricator
Differential D9408

Make ObjectItem default as "Card"
ClosedPublic
Actions

Authored by chad on Jun 6 2014, 6:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 2, 5:09 AM
Unknown Object (File)
Sat, Jan 25, 4:40 PM
Unknown Object (File)
Tue, Jan 21, 1:56 PM
Unknown Object (File)
Mon, Jan 13, 4:16 PM
Unknown Object (File)
Dec 27 2024, 2:20 PM
Unknown Object (File)
Dec 26 2024, 2:38 PM
Unknown Object (File)
Dec 24 2024, 2:40 AM
Unknown Object (File)
Dec 23 2024, 4:40 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP41ef6824be87: Make ObjectItem default as "Card"
Summary

This went smoother than expeced. Makes the rounded Card the default, also tweaked selected state a little.

Test Plan

Test UIExamples, Maniphest, Home, Differential, Harbormaster, Audit. Everything seems normal

undefined (401×792 px, 43 KB)

undefined (958×474 px, 46 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 22460.Jun 6 2014, 6:58 PM
chad retitled this revision from to Make ObjectItem default as "Card".
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 6 2014, 6:58 PM
Harbormaster completed remote builds in B903: Diff 22460.Jun 6 2014, 6:59 PM
chad edited the test plan for this revision. (Show Details)Jun 6 2014, 7:00 PM
epriestley accepted this revision.Jun 7 2014, 7:05 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2014, 7:05 PM
chad closed this revision.Jun 7 2014, 7:12 PM
chad updated this revision to Diff 22489.

Closed by commit rP41ef6824be87 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
audit/
view/
1 line
config/
controller/
1 line
daemon/
view/
1 line
differential/
view/
1 line
harbormaster/
query/
1 line
herald/
query/
3 lines
1 line
view/
1 line
home/
controller/
1 line
maniphest/
view/
1 line
phriction/
controller/
1 line
1 line
project/
controller/
1 line
repository/
query/
1 line
settings/
panel/
2 lines
uiexample/
examples/
2 lines
6 lines
view/
phui/
10 lines
webroot/
rsrc/
css/
phui/
52 lines

Diff 22489

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/audit/view/PhabricatorAuditListView.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIssueListController.php

Loading...
View Options

src/applications/daemon/view/PhabricatorDaemonLogListView.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionListView.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

Loading...
View Options

src/applications/herald/query/HeraldRuleSearchEngine.php

Loading...
View Options

src/applications/herald/query/HeraldTranscriptSearchEngine.php

Loading...
View Options

src/applications/herald/view/HeraldRuleEditHistoryView.php

Loading...
View Options

src/applications/home/controller/PhabricatorHomeQuickCreateController.php

Loading...
View Options

src/applications/maniphest/view/ManiphestTaskListView.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDiffController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionHistoryController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelExternalAccounts.php

Loading...
View Options

src/applications/uiexample/examples/PHUIObjectItemListExample.php

Loading...
View Options

src/applications/uiexample/examples/PHUIWorkboardExample.php

Loading...
View Options

src/view/phui/PHUIObjectItemListView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility