Fixing top margin of first heading in phriction if toc is visible
Needs RevisionPublic
Actions

Authored by bluehawk on Jun 5 2014, 5:55 PM.

Tags

None

Referenced Files

	F14023580: D9393.diff
	Thu, Nov 7, 2:55 AM

	F14017606: D9393.diff
	Mon, Nov 4, 7:34 PM

	F14008063: D9393.diff
	Tue, Oct 29, 3:02 PM

	F13989334: D9393.id22403.diff
	Mon, Oct 21, 7:49 PM

	F13964973: D9393.diff
	Tue, Oct 15, 11:03 PM

	Unknown Object (File)
	Oct 1 2024, 1:25 PM

	Unknown Object (File)
	Sep 27 2024, 3:36 AM

	Unknown Object (File)
	Sep 8 2024, 2:40 AM

View All Files

Subscribers

epriestley

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Summary

The selector ":first-child" on the headings misses if the toc is visible

Test Plan

View phriction page with and without a toc.

Diff Detail

Repository

rP Phabricator

Branch

phriction-first-heading

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 875
Build 875: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

bluehawk updated this revision to Diff 22403.Jun 5 2014, 5:55 PM

bluehawk retitled this revision from to Fixing top margin of first heading in phriction if toc is visible.

bluehawk updated this object.

bluehawk edited the test plan for this revision. (Show Details)

bluehawk added a reviewer: chad.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 5 2014, 5:55 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Before fix:

After fix:

Harbormaster completed remote builds in B875: Diff 22403.Jun 5 2014, 5:56 PM

Pretty sure this is obsolete now since Phriction has gone through like 5 redesigns.

This revision now requires changes to proceed.Nov 2 2015, 4:50 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

core/

remarkup.css

12 lines

Diff 22403

View Options

resources/celerity/map.php