Page MenuHomePhabricator

FontAwesome RemarkupBar
ClosedPublic

Authored by chad on Jun 5 2014, 4:35 AM.
Tags
None
Referenced Files
F14000919: D9385.diff
Fri, Oct 25, 2:22 AM
F13986094: D9385.id.diff
Mon, Oct 21, 12:31 AM
F13986084: D9385.id.diff
Mon, Oct 21, 12:28 AM
F13985582: D9385.id.diff
Sun, Oct 20, 9:30 PM
F13985087: D9385.diff
Sun, Oct 20, 5:58 PM
F13984569: D9385.id.diff
Sun, Oct 20, 2:19 PM
F13977775: D9385.diff
Fri, Oct 18, 8:00 PM
F13977764: D9385.diff
Fri, Oct 18, 7:57 PM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPdbebfea9cc1c: FontAwesome RemarkupBar
Summary

Replaces the icons with fonts from FontAwesome. Up in the air about the meme icon. Thoughts?

Also removed the second fullscreen/normal state. Seems obvious what it does, but assume someone complained previously?

Test Plan

Tested all the icon states and made sure they still worked. Test fullscreen and help.

undefined (291×858 px, 19 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad retitled this revision from to FontAwesome RemarkupBar.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Yeah, I don't like the Reddit icon. The idea is cute, but using a brand logo feels sketchy to me.

Maybe fa-leaf (this is meaningless, but also the "macro" application icon), fa-lightbulb-o, or fa-gavel (sort of like a stamp, maybe?), or fa-book (select from a list of macros?) or fa-paw? I don't really see any strong candidates.

We could also retain the icon in this case, but that's kind of a pain.

This revision now requires changes to proceed.Jun 5 2014, 4:39 PM
chad edited edge metadata.
  • change reddit to meh
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2014, 5:26 PM
chad updated this revision to Diff 22400.

Closed by commit rPdbebfea9cc1c (authored by @chad).