Page MenuHomePhabricator
Differential D9356

Dashboard panel CSS fixes
ClosedPublic
Actions

Authored by chad on Jun 3 2014, 4:50 AM.
Tags
None
Referenced Files
F14812015: D9356.id22303.diff
Mon, Jan 27, 5:39 AM
F14812014: D9356.id22280.diff
Mon, Jan 27, 5:39 AM
F14812012: D9356.id.diff
Mon, Jan 27, 5:39 AM
F14812011: D9356.id22279.diff
Mon, Jan 27, 5:39 AM
F14812009: D9356.id22304.diff
Mon, Jan 27, 5:38 AM
F14811935: D9356.diff
Mon, Jan 27, 5:29 AM
Unknown Object (File)
Fri, Jan 17, 8:24 AM
Unknown Object (File)
Tue, Jan 14, 1:34 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP389a88d4bc07: Dashboard panel CSS fixes
Summary

Fixes a couple of spacing issues on object-lists

Test Plan

Test some object lists, desktop, mobile

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 22279.Jun 3 2014, 4:50 AM
chad retitled this revision from to Dashboard panel CSS fixes.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 3 2014, 4:50 AM
Harbormaster completed remote builds in B817: Diff 22279.Jun 3 2014, 4:51 AM
chad updated this revision to Diff 22280.Jun 3 2014, 5:12 AM
  • add code for grippable
chad added a comment.Jun 3 2014, 5:13 AM

I'm just hiding the grippable stuff for now, assume we can fix that down the road if people want it (there were many other bugs with it).

Harbormaster completed remote builds in B818: Diff 22280.Jun 3 2014, 5:13 AM
epriestley requested changes to this revision.Jun 3 2014, 1:10 PM
epriestley edited edge metadata.

I think the grippable stuff is important, can you file an issue with bugs instead of hiding it?

This revision now requires changes to proceed.Jun 3 2014, 1:10 PM
chad updated this revision to Diff 22303.Jun 3 2014, 7:08 PM
chad edited edge metadata.
  • remove grippable code
epriestley accepted this revision.Jun 3 2014, 7:08 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2014, 7:08 PM
chad added a comment.Jun 3 2014, 7:09 PM

There is already a task, I'll dig it up. Basically anytime you drag and drop a task, it's UI defaults are "Workboard" and not necessarily the UI you were working on.

Harbormaster completed remote builds in B833: Diff 22303.Jun 3 2014, 7:09 PM
chad closed this revision.Jun 3 2014, 7:11 PM
chad updated this revision to Diff 22304.

Closed by commit rP389a88d4bc07 (authored by @chad).

epriestley added a comment.Jun 3 2014, 7:11 PM

Ohh, this is drag-and-dropping tasks in panels? I don't think that's important. We can disable it properly in the panel renderer rather than just hiding it in CSS, though.

chad added a comment.Jun 3 2014, 7:13 PM

oh, is there a place I can override PHUIObjectListView at a PanelRendering level?

epriestley added a comment.Jun 3 2014, 7:14 PM

Maybe! I forget if I wrote it yet or not.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
phui/
4 lines

Diff 22304

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility