Page MenuHomePhabricator

Expose commit description/author/summary to HarborMaster. Also, enable posting HTTP POST data
AbandonedPublic

Authored by oskall on Jun 1 2014, 10:35 PM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

I needed those for a Slack integration. I hope that's ok.

Test Plan

Manually tested the integration, and have been using it for a while. I'm not familiar with the test policy, but let me know if you want me to write some tests (and point me in the right direction maybe?)

Diff Detail

Repository
rP Phabricator
Branch
harbor-master-add-variables
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 801
Build 801: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

oskall retitled this revision from to Expose commit description/author/summary to HarborMaster. Also, enable posting HTTP POST data.
oskall updated this object.
oskall edited the test plan for this revision. (Show Details)
oskall added a reviewer: epriestley.
epriestley edited edge metadata.

The receiver should use Conduit to retrieve additional information (e.g., call differential.query with the revision PHID), rather than expect all possible data to be POST'd.

You should consider using feed.http-hooks instead of using Harbormaster to post messages. Harbormaster tasks may have lower priority in the future.

This revision now requires changes to proceed.Jun 2 2014, 10:39 PM