Page MenuHomePhabricator

Make it much easier to add one-off event listeners
ClosedPublic

Authored by epriestley on May 22 2014, 10:13 PM.
Tags
None
Referenced Files
F14480947: D9262.id.diff
Sun, Dec 29, 11:58 PM
Unknown Object (File)
Tue, Dec 10, 6:25 AM
Unknown Object (File)
Sun, Dec 8, 8:56 PM
Unknown Object (File)
Sun, Dec 8, 8:56 PM
Unknown Object (File)
Sun, Dec 8, 8:43 PM
Unknown Object (File)
Sun, Dec 8, 8:37 PM
Unknown Object (File)
Fri, Dec 6, 3:53 PM
Unknown Object (File)
Thu, Dec 5, 10:20 PM
Subscribers

Details

Summary

Ref T4657. Right now, you have to muck with events.listeners to install listeners. Instead, automatically install all subclasses of AutoEventListener.

Primarily, this makes it easier to resolve requests with "drop this file in src/extensions/, no warranty", which seems to have worked well so far in resolving things like custom remarkup rules, etc.

Test Plan
  • Added such a listener, had it autoregister.
  • Clicked around and saw the effects of normal listeners.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Make it much easier to add one-off event listeners.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
This revision is now accepted and ready to land.May 22 2014, 10:16 PM
epriestley updated this revision to Diff 21997.

Closed by commit rP27a369d15acc (authored by @epriestley).