Fixes T5143. Currently, if your allowed domain is "example.com", we reject signups from "@Example.com".
Instead, lowercase both parts before performing the check.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T5143: Make "auth.email-domains" case-insensitive
- Commits
- Restricted Diffusion Commit
rPa76f61f7e183: Make auth.email-domains case-insensitive
- Before patch:
- Set allowed domains to "yghe.net".
- Tried "x@yghe.net", no error.
- Tried "x@xxxy.net", error.
- Tried "x@yghE.net", incorrectly results in an error.
- After patch:
- Set allowed domains to "yghe.net".
- Tried "x@yghe.net", no error.
- Tried "x@xxxy.net", error.
- Tried "x@yghE.net", this correctly no longer produces an error.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Maybe /config/edit/auth.email-domains/ needs an update to text that things match in a case insensitive way?
| src/applications/people/storage/PhabricatorUserEmail.php | ||
|---|---|---|
| 94 | I was surprised this wasn't saved in a strtolower'd format. whatevs tho. | |
Comment Actions
We could try harder to normalize on input, but I think it gets a bit messy: if it comes from a config file we can't do anything about it at write-time since it's in an immutable PHP file, for instance. This approach means we don't have to deal with that case, don't have to migrate any data, etc.