Page MenuHomePhabricator

Make password reset emails use one-time tokens
ClosedPublic

Authored by epriestley on May 22 2014, 1:41 AM.

Details

Summary

Ref T4398. This code hadn't been touched in a while and had a few crufty bits.

One Time Resets: Currently, password reset (and similar links) are valid for about 48 hours, but we always use one token to generate them (it's bound to the account). This isn't horrible, but it could be better, and it produces a lot of false positives on HackerOne.

Instead, use TemporaryTokens to make each link one-time only and good for no more than 24 hours.

Coupling of Email Verification and One-Time Login: Currently, one-time login links ("password reset links") are tightly bound to an email address, and using a link verifies that email address.

This is convenient for "Welcome" emails, so the user doesn't need to go through two rounds of checking email in order to login, then very their email, then actually get access to Phabricator.

However, for other types of these links (like those generated by bin/auth recover) there's no need to do any email verification.

Instead, make the email verification part optional, and use it on welcome links but not other types of links.

Message Customization: These links can come out of several workflows: welcome, password reset, username change, or bin/auth recover. Add a hint to the URI so the text on the page can be customized a bit to help users through the workflow.

Reset Emails Going to Main Account Email: Previously, we would send password reset email to the user's primary account email. However, since we verify email coming from reset links this isn't correct and could allow a user to verify an email without actually controlling it.

Since the user needs a real account in the first place this does not seem useful on its own, but might be a component in some other attack. The user might also no longer have access to their primary account, in which case this wouldn't be wrong, but would not be very useful.

Mitigate this in two ways:

  • First, send to the actual email address the user entered, not the primary account email address.
  • Second, don't let these links verify emails: they're just login links. This primarily makes it more difficult for an attacker to add someone else's email to their account, send them a reset link, get them to login and implicitly verify the email by not reading very carefully, and then figure out something interesting to do (there's currently no followup attack here, but allowing this does seem undesirable).

Password Reset Without Old Password: After a user logs in via email, we send them to the password settings panel (if passwords are enabled) with a code that lets them set a new password without knowing the old one.

Previously, this code was static and based on the email address. Instead, issue a one-time code.

Jump Into Hisec: Normally, when a user who has multi-factor auth on their account logs in, we prompt them for factors but don't put them in high security. You usually don't want to go do high-security stuff immediately after login, and it would be confusing and annoying if normal logins gave you a "YOU ARE IN HIGH SECURITY" alert bubble.

However, if we're taking you to the password reset screen, we do want to put the user in high security, since that screen requires high security. If we don't do this, the user gets two factor prompts in a row.

To accomplish this, we set a cookie when we know we're sending the user into a high security workflow. This cookie makes login finalization upgrade all the way from "partial" to "high security", instead of stopping halfway at "normal". This is safe because the user has just passed a factor check; the only reason we don't normally do this is to reduce annoyance.

Some UI Cleanup: Some of this was using really old UI. Modernize it a bit.

Test Plan
  • One Time Resets
    • Used a reset link.
    • Tried to reuse a reset link, got denied.
    • Verified each link is different.
  • Coupling of Email Verification and One-Time Login
    • Verified that bin/auth, password reset, and username change links do not have an email verifying URI component.
    • Tried to tack one on, got denied.
    • Used the welcome email link to login + verify.
    • Tried to mutate the URI to not verify, or verify something else: got denied.
  • Message Customization
    • Viewed messages on the different workflows. They seemed OK.
  • Reset Emails Going to Main Account Email
    • Sent password reset email to non-primary email.
    • Received email at specified address.
    • Verified it does not verify the address.
  • Password Reset Without Old Password
    • Reset password without knowledge of old one after email reset.
    • Tried to do that without a key, got denied.
    • Tried to reuse a key, got denied.
  • Jump Into Hisec
    • Logged in with MFA user, got factor'd, jumped directly into hisec.
    • Logged in with non-MFA user, no factors, normal password reset.
  • Some UI Cleanup
    • Viewed new UI.
  • Misc
    • Created accounts, logged in with welcome link, got verified.
    • Changed a username, used link to log back in.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley retitled this revision from to Make password reset emails use one-time tokens.May 22 2014, 1:41 AM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley updated this revision to Diff 21969.
btrahan edited edge metadata.May 22 2014, 4:51 PM
btrahan accepted this revision.

Very nice cleanup. Thanks for the thorough test plan too.

This revision is now accepted and ready to land.May 22 2014, 4:51 PM
epriestley closed this revision.May 22 2014, 5:41 PM
epriestley updated this revision to Diff 21982.

Closed by commit rPf1534e6feb6a (authored by @epriestley).